From patchwork Tue Jan 26 20:41:25 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Robert Jarzmik X-Patchwork-Id: 573464 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 05C76140BAE for ; Wed, 27 Jan 2016 07:41:30 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751251AbcAZUl2 (ORCPT ); Tue, 26 Jan 2016 15:41:28 -0500 Received: from smtp12.smtpout.orange.fr ([80.12.242.134]:41354 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751024AbcAZUl2 (ORCPT ); Tue, 26 Jan 2016 15:41:28 -0500 Received: from belgarion ([86.199.70.65]) by mwinf5d35 with ME id AkhR1s0051QWASW03khR9r; Tue, 26 Jan 2016 21:41:26 +0100 X-ME-Helo: belgarion X-ME-Auth: amFyem1pay5yb2JlcnRAb3JhbmdlLmZy X-ME-Date: Tue, 26 Jan 2016 21:41:26 +0100 X-ME-IP: 86.199.70.65 From: Robert Jarzmik To: Marcel Ziswiler Cc: Linus Walleij , Alexandre Courbot , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [REGRESSION] gpio: pxa: change initcall level second attempt References: <1453598314.3178.12.camel@ziswiler.com> <87oac9ag32.fsf@belgarion.home> X-URL: http://belgarath.falguerolles.org/ Date: Tue, 26 Jan 2016 21:41:25 +0100 In-Reply-To: <87oac9ag32.fsf@belgarion.home> (Robert Jarzmik's message of "Mon, 25 Jan 2016 15:28:33 +0100") Message-ID: <87y4bc845m.fsf@belgarion.home> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.4 (gnu/linux) MIME-Version: 1.0 Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Robert Jarzmik writes: >> Have you seen this as well or do you know how exactly that should be >> worked around? > Hi Marcel, > > I haven't seen that before on my devicetree boards, I will try this evening on > top of next-20160125. > > Could you activate the debug logs in drivers/of/irq.c please, and send me > privately your boot dmesg ? And I'd like to see your board .dts file and your > .config also, to compare with mine for the mioa701. > > I think in your dm9000 case we have this callstack : > - of_irq_get() > of_irq_parse_one() => fails, for an unknown reason to me > => I would have expected it return 0 > => the following irq_find_host() would return > -EPROBE_DEFER, that's what I'd expect > irq_create_of_mapping() > irq_create_fwspec_mapping() > => error message > > What is probable is that gpio-pxa was not probed yet, and this triggers the > error. What I don't understand is why you don't end up with -EPROBE_DEFER, > that's why I'd like to have your logs. BTW, would you try also with the patch at the end of this mail applied ? Just to verify a wild guess. Cheers. diff --git a/drivers/net/ethernet/davicom/dm9000.c b/drivers/net/ethernet/davicom/dm9000.c index cf94b72dbacd..2c532011ae8e 100644 --- a/drivers/net/ethernet/davicom/dm9000.c +++ b/drivers/net/ethernet/davicom/dm9000.c @@ -1509,6 +1509,10 @@ dm9000_probe(struct platform_device *pdev) goto out; } + ndev->irq = platform_get_irq(pdev, 0); + if (ndev->irq < 0) + return ndev->irq; + db->irq_wake = platform_get_irq(pdev, 1); if (db->irq_wake >= 0) { dev_dbg(db->dev, "wakeup irq %d\n", db->irq_wake); @@ -1570,7 +1574,6 @@ dm9000_probe(struct platform_device *pdev) /* fill in parameters for net-dev structure */ ndev->base_addr = (unsigned long)db->io_addr; - ndev->irq = db->irq_res->start; /* ensure at least we have a default set of IO routines */ dm9000_set_io(db, iosize);