Message ID | 375d76dc3fe344f5168e8155211422de59f0efa0.1495814557.git.jan.kiszka@siemens.com |
---|---|
State | New |
Headers | show |
On Fri, May 26, 2017 at 7:02 PM, Jan Kiszka <jan.kiszka@siemens.com> wrote: > Set the parent of the exar gpiochip to its platform device, like other > gpiochips are doing it. In order to keep the relationship discoverable > for ACPI systems, set the platform device companion to the PCI device. > Setting companion is a right thing to do (like it's done in other similar cases) Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com> > Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com> > --- > drivers/gpio/gpio-exar.c | 2 +- > drivers/tty/serial/8250/8250_exar.c | 2 ++ > 2 files changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpio/gpio-exar.c b/drivers/gpio/gpio-exar.c > index f3585a184f39..1a629831d45b 100644 > --- a/drivers/gpio/gpio-exar.c > +++ b/drivers/gpio/gpio-exar.c > @@ -142,7 +142,7 @@ static int gpio_exar_probe(struct platform_device *pdev) > > sprintf(exar_gpio->name, "exar_gpio%d", index); > exar_gpio->gpio_chip.label = exar_gpio->name; > - exar_gpio->gpio_chip.parent = &pcidev->dev; > + exar_gpio->gpio_chip.parent = &pdev->dev; > exar_gpio->gpio_chip.direction_output = exar_direction_output; > exar_gpio->gpio_chip.direction_input = exar_direction_input; > exar_gpio->gpio_chip.get_direction = exar_get_direction; > diff --git a/drivers/tty/serial/8250/8250_exar.c b/drivers/tty/serial/8250/8250_exar.c > index 0f4b236d7e68..ee4b142f3ed0 100644 > --- a/drivers/tty/serial/8250/8250_exar.c > +++ b/drivers/tty/serial/8250/8250_exar.c > @@ -9,6 +9,7 @@ > * it under the terms of the GNU General Public License as published by > * the Free Software Foundation; either version 2 of the License. > */ > +#include <linux/acpi.h> > #include <linux/io.h> > #include <linux/kernel.h> > #include <linux/module.h> > @@ -204,6 +205,7 @@ xr17v35x_register_gpio(struct pci_dev *pcidev) > return NULL; > > pdev->dev.parent = &pcidev->dev; > + ACPI_COMPANION_SET(&pdev->dev, ACPI_COMPANION(&pcidev->dev)); > > if (platform_device_add(pdev) < 0) { > platform_device_put(pdev); > -- > 2.12.0 >
On Fri, May 26, 2017 at 6:02 PM, Jan Kiszka <jan.kiszka@siemens.com> wrote: > Set the parent of the exar gpiochip to its platform device, like other > gpiochips are doing it. In order to keep the relationship discoverable > for ACPI systems, set the platform device companion to the PCI device. > > Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com> Acked-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/gpio/gpio-exar.c b/drivers/gpio/gpio-exar.c index f3585a184f39..1a629831d45b 100644 --- a/drivers/gpio/gpio-exar.c +++ b/drivers/gpio/gpio-exar.c @@ -142,7 +142,7 @@ static int gpio_exar_probe(struct platform_device *pdev) sprintf(exar_gpio->name, "exar_gpio%d", index); exar_gpio->gpio_chip.label = exar_gpio->name; - exar_gpio->gpio_chip.parent = &pcidev->dev; + exar_gpio->gpio_chip.parent = &pdev->dev; exar_gpio->gpio_chip.direction_output = exar_direction_output; exar_gpio->gpio_chip.direction_input = exar_direction_input; exar_gpio->gpio_chip.get_direction = exar_get_direction; diff --git a/drivers/tty/serial/8250/8250_exar.c b/drivers/tty/serial/8250/8250_exar.c index 0f4b236d7e68..ee4b142f3ed0 100644 --- a/drivers/tty/serial/8250/8250_exar.c +++ b/drivers/tty/serial/8250/8250_exar.c @@ -9,6 +9,7 @@ * it under the terms of the GNU General Public License as published by * the Free Software Foundation; either version 2 of the License. */ +#include <linux/acpi.h> #include <linux/io.h> #include <linux/kernel.h> #include <linux/module.h> @@ -204,6 +205,7 @@ xr17v35x_register_gpio(struct pci_dev *pcidev) return NULL; pdev->dev.parent = &pcidev->dev; + ACPI_COMPANION_SET(&pdev->dev, ACPI_COMPANION(&pcidev->dev)); if (platform_device_add(pdev) < 0) { platform_device_put(pdev);
Set the parent of the exar gpiochip to its platform device, like other gpiochips are doing it. In order to keep the relationship discoverable for ACPI systems, set the platform device companion to the PCI device. Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com> --- drivers/gpio/gpio-exar.c | 2 +- drivers/tty/serial/8250/8250_exar.c | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-)