| Message ID | 20241024151044.4038250-1-andriy.shevchenko@linux.intel.com |
|---|---|
| State | New |
| Headers | show |
| Series | [v1,1/1] pinctrl: intel: Add a human readable decoder for pull bias values | expand |
On Thu, Oct 24, 2024 at 06:10:44PM +0300, Andy Shevchenko wrote: > Add a human readable decoder for pull bias values in the comment. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> This is nice! Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
On Thu, Oct 24, 2024 at 06:28:02PM +0300, Mika Westerberg wrote: > On Thu, Oct 24, 2024 at 06:10:44PM +0300, Andy Shevchenko wrote: > > Add a human readable decoder for pull bias values in the comment. > > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > This is nice! > > Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com> Pushed to my review and testing queue, thanks!
diff --git a/drivers/pinctrl/intel/pinctrl-intel.c b/drivers/pinctrl/intel/pinctrl-intel.c index f6f6d3970d5d..86cabb73904f 100644 --- a/drivers/pinctrl/intel/pinctrl-intel.c +++ b/drivers/pinctrl/intel/pinctrl-intel.c @@ -85,6 +85,18 @@ #define PADCFG1_TERM_UP BIT(13) #define PADCFG1_TERM_SHIFT 10 #define PADCFG1_TERM_MASK GENMASK(12, 10) +/* + * Bit 0 Bit 1 Bit 2 Value, Ohms + * + * 0 0 0 - + * 0 0 1 20000 + * 0 1 0 5000 + * 0 1 1 ~4000 + * 1 0 0 1000 (if supported) + * 1 0 1 ~952 (if supported) + * 1 1 0 ~833 (if supported) + * 1 1 1 ~800 (if supported) + */ #define PADCFG1_TERM_20K BIT(2) #define PADCFG1_TERM_5K BIT(1) #define PADCFG1_TERM_4K (BIT(2) | BIT(1))
Add a human readable decoder for pull bias values in the comment. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- drivers/pinctrl/intel/pinctrl-intel.c | 12 ++++++++++++ 1 file changed, 12 insertions(+)