diff mbox series

gpio: sysfs: constify gpio class

Message ID 20241014121831.106532-1-brgl@bgdev.pl
State New
Headers show
Series gpio: sysfs: constify gpio class | expand

Commit Message

Bartosz Golaszewski Oct. 14, 2024, 12:18 p.m. UTC 
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

All class functions used here take a const pointer to the class
structure. We can constify gpio_class.

While at it: remove a stray newline and use a tab in the struct
definition for consistency with the line above.

Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
---
 drivers/gpio/gpiolib-sysfs.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

Comments

Linus Walleij Oct. 15, 2024, 8:02 a.m. UTC | #1 
On Mon, Oct 14, 2024 at 2:18 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote:

> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>
> All class functions used here take a const pointer to the class
> structure. We can constify gpio_class.
>
> While at it: remove a stray newline and use a tab in the struct
> definition for consistency with the line above.
>
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij
Bartosz Golaszewski Oct. 17, 2024, 6:57 a.m. UTC | #2 
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>


On Mon, 14 Oct 2024 14:18:30 +0200, Bartosz Golaszewski wrote:
> All class functions used here take a const pointer to the class
> structure. We can constify gpio_class.
> 
> While at it: remove a stray newline and use a tab in the struct
> definition for consistency with the line above.
> 
> 
> [...]

Applied, thanks!

[1/1] gpio: sysfs: constify gpio class
      commit: b6f7aeaf1bfd8d78d55868f0857e397b06a01777

Best regards,
diff mbox series

Patch

diff --git a/drivers/gpio/gpiolib-sysfs.c b/drivers/gpio/gpiolib-sysfs.c
index 20426d6e04d5..0c713baa7784 100644
--- a/drivers/gpio/gpiolib-sysfs.c
+++ b/drivers/gpio/gpiolib-sysfs.c
@@ -549,12 +549,11 @@  static struct attribute *gpio_class_attrs[] = {
 };
 ATTRIBUTE_GROUPS(gpio_class);
 
-static struct class gpio_class = {
+static const struct class gpio_class = {
 	.name =		"gpio",
-	.class_groups = gpio_class_groups,
+	.class_groups =	gpio_class_groups,
 };
 
-
 /**
  * gpiod_export - export a GPIO through sysfs
  * @desc: GPIO to make available, already requested