| Message ID | 20240815071651.3645949-4-ye.zhang@rock-chips.com |
|---|---|
| State | New |
| Headers | show |
| Series | gpio: rockchip: Update the GPIO driver | expand |
On Thu, Aug 15, 2024 at 9:17 AM Ye Zhang <ye.zhang@rock-chips.com> wrote: > > Set input direction to avoid FLAG_IS_OUT in gpiochip_lock_as_irq > That I can tell from the code. The commit message should say *why* you're doing something. Bart > Signed-off-by: Ye Zhang <ye.zhang@rock-chips.com> > --- > drivers/gpio/gpio-rockchip.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpio/gpio-rockchip.c b/drivers/gpio/gpio-rockchip.c > index b2f26a16b1f6..8949324ed816 100644 > --- a/drivers/gpio/gpio-rockchip.c > +++ b/drivers/gpio/gpio-rockchip.c > @@ -475,6 +475,8 @@ static int rockchip_irq_reqres(struct irq_data *d) > struct irq_chip_generic *gc = irq_data_get_irq_chip_data(d); > struct rockchip_pin_bank *bank = gc->private; > > + rockchip_gpio_direction_input(&bank->gpio_chip, d->hwirq); > + > return gpiochip_reqres_irq(&bank->gpio_chip, d->hwirq); > } > > -- > 2.34.1 >
diff --git a/drivers/gpio/gpio-rockchip.c b/drivers/gpio/gpio-rockchip.c index b2f26a16b1f6..8949324ed816 100644 --- a/drivers/gpio/gpio-rockchip.c +++ b/drivers/gpio/gpio-rockchip.c @@ -475,6 +475,8 @@ static int rockchip_irq_reqres(struct irq_data *d) struct irq_chip_generic *gc = irq_data_get_irq_chip_data(d); struct rockchip_pin_bank *bank = gc->private; + rockchip_gpio_direction_input(&bank->gpio_chip, d->hwirq); + return gpiochip_reqres_irq(&bank->gpio_chip, d->hwirq); }
Set input direction to avoid FLAG_IS_OUT in gpiochip_lock_as_irq Signed-off-by: Ye Zhang <ye.zhang@rock-chips.com> --- drivers/gpio/gpio-rockchip.c | 2 ++ 1 file changed, 2 insertions(+)