From patchwork Fri Jul 19 14:44:10 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 1962522 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=J9OBJytD; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=147.75.199.223; helo=ny.mirrors.kernel.org; envelope-from=linux-gpio+bounces-8303-incoming=patchwork.ozlabs.org@vger.kernel.org; receiver=patchwork.ozlabs.org) Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org [147.75.199.223]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4WQXWQ5C4Qz1xpQ for ; Sat, 20 Jul 2024 00:44:34 +1000 (AEST) Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 5D5281C2151B for ; Fri, 19 Jul 2024 14:44:32 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 6267481211; Fri, 19 Jul 2024 14:44:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="J9OBJytD" X-Original-To: linux-gpio@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1CC831B86D6; Fri, 19 Jul 2024 14:44:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721400268; cv=none; b=L8jZCsrJmrdT105g88zRmTWbzsPO7NetpQGJCtuhxLX7qY15+wFyI1wuxIUI0tkq2QyqOGJZXC7F2Y9odlNSvTZotCceu1K0aB56fgImOk49wc4g3hubGiB2aQof1L7FLCtE9auf6/IQgCUBggVLM6zsvaVEMjMh34kpLb01ROU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721400268; c=relaxed/simple; bh=7Uwer+uc6drSXe/I1J0kZc+yIHVn2PCgJx++GUkKvkY=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=pCYrrc8fal2H732Gikcs4mDxUhXP8wiD/mLF2f+AGfC/OetyXKbK6L6Ih/FwCnIhPw/kN1z365DsIs7X6a3rwD7os4VJZxd+pPgLdehEzTGZrBHJBBTRUNReOIf5kK8+PWuK3jRGKItr4eBrJ1P/1ThYuosHMoFRxewIM7P8y7g= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=J9OBJytD; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 471ADC32782; Fri, 19 Jul 2024 14:44:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1721400267; bh=7Uwer+uc6drSXe/I1J0kZc+yIHVn2PCgJx++GUkKvkY=; h=From:To:Cc:Subject:Date:From; b=J9OBJytDVv0iqSBIgiRna9sj96nQ6P/f1nuByllnrRbjzAOYnJNsihFQ72KQMlY1v LwceSnQwfsGVp1mtW/1R3IVZAVETp5bTvISuVy/NGVl1Y24Gz+neIyyqhfBVlFhnOf VjIoNsaMuGof5/8ugBOcL2M0cJcdcnZ4nFmpZs6MxpWr9wMyrhqQC2hrDVzyLu7LXi nb5jnJLLImlnVxjF0MaxpaehH2kmVKTxEuFH7WEwoKOfiFaGvOUbBb4G3JRsJgTXSg zpf6yB/HuU/uRtzdLTad1s3CGcqdA8wxflWIqhlwN8ZwR2PXLyO2VrxkIDDJLgFP44 R4DWhOhPYwOYg== From: Arnd Bergmann To: Linus Walleij , Bartosz Golaszewski Cc: Arnd Bergmann , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] [v2] gpio: virtuser: avoid non-constant format string Date: Fri, 19 Jul 2024 16:44:10 +0200 Message-Id: <20240719144422.2082394-1-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: Arnd Bergmann Using a string variable as an sprintf format is potentially dangerous, and gcc can warn about this: drivers/gpio/gpio-virtuser.c: In function 'gpio_virtuser_dbgfs_init_line_attrs': drivers/gpio/gpio-virtuser.c:808:9: error: format not a string literal and no format arguments [-Werror=format-security] 808 | sprintf(data->consumer, id); | ^~~~~~~ Change it to a simpler strscpy() instead to just copy it and check the destination buffer size. Fixes: 91581c4b3f29 ("gpio: virtuser: new virtual testing driver for the GPIO API") Signed-off-by: Arnd Bergmann --- drivers/gpio/gpio-virtuser.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpio/gpio-virtuser.c b/drivers/gpio/gpio-virtuser.c index 0e0d55da4f01..ccc47ea0b3e1 100644 --- a/drivers/gpio/gpio-virtuser.c +++ b/drivers/gpio/gpio-virtuser.c @@ -805,7 +805,7 @@ static int gpio_virtuser_dbgfs_init_line_attrs(struct device *dev, return -ENOMEM; data->ad.desc = desc; - sprintf(data->consumer, id); + strscpy(data->consumer, id); atomic_set(&data->irq, 0); atomic_set(&data->irq_count, 0);