| Message ID | 20240510160534.2424281-1-andriy.shevchenko@linux.intel.com |
|---|---|
| State | New |
| Headers | show |
| Series | [v1,1/1] gpiolib: Show more info for interrupt only lines in debugfs | expand |
On Fri, May 10, 2024 at 6:05 PM Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > Show more info for interrupt only lines in debugfs. It's useful > to monitor the lines that have been never requested as GPIOs, > but IRQs. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Excellent patch. Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij
On Fri, May 10, 2024 at 6:05 PM Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > > Show more info for interrupt only lines in debugfs. It's useful > to monitor the lines that have been never requested as GPIOs, > but IRQs. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > --- > > For the reference. May be applied together with > 20240508144741.1270912-1-andriy.shevchenko@linux.intel.com > as a precursor. > > drivers/gpio/gpiolib.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c > index 1f1673552767..4cd7e05f3e5b 100644 > --- a/drivers/gpio/gpiolib.c > +++ b/drivers/gpio/gpiolib.c > @@ -4801,11 +4801,11 @@ static void gpiolib_dbg_show(struct seq_file *s, struct gpio_device *gdev) > > for_each_gpio_desc(gc, desc) { > guard(srcu)(&desc->srcu); > - if (test_bit(FLAG_REQUESTED, &desc->flags)) { > + is_irq = test_bit(FLAG_USED_AS_IRQ, &desc->flags); > + if (is_irq || test_bit(FLAG_REQUESTED, &desc->flags)) { > gpiod_get_direction(desc); > is_out = test_bit(FLAG_IS_OUT, &desc->flags); > value = gpio_chip_get_value(gc, desc); > - is_irq = test_bit(FLAG_USED_AS_IRQ, &desc->flags); > active_low = test_bit(FLAG_ACTIVE_LOW, &desc->flags); > seq_printf(s, " gpio-%-3u (%-20.20s|%-20.20s) %s %s %s%s\n", > gpio, desc->name ?: "", gpiod_get_label(desc), > -- > 2.43.0.rc1.1336.g36b5255a03ac > This now conflicts with current next, please rebase and resend. Bart
diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c index 1f1673552767..4cd7e05f3e5b 100644 --- a/drivers/gpio/gpiolib.c +++ b/drivers/gpio/gpiolib.c @@ -4801,11 +4801,11 @@ static void gpiolib_dbg_show(struct seq_file *s, struct gpio_device *gdev) for_each_gpio_desc(gc, desc) { guard(srcu)(&desc->srcu); - if (test_bit(FLAG_REQUESTED, &desc->flags)) { + is_irq = test_bit(FLAG_USED_AS_IRQ, &desc->flags); + if (is_irq || test_bit(FLAG_REQUESTED, &desc->flags)) { gpiod_get_direction(desc); is_out = test_bit(FLAG_IS_OUT, &desc->flags); value = gpio_chip_get_value(gc, desc); - is_irq = test_bit(FLAG_USED_AS_IRQ, &desc->flags); active_low = test_bit(FLAG_ACTIVE_LOW, &desc->flags); seq_printf(s, " gpio-%-3u (%-20.20s|%-20.20s) %s %s %s%s\n", gpio, desc->name ?: "", gpiod_get_label(desc),
Show more info for interrupt only lines in debugfs. It's useful to monitor the lines that have been never requested as GPIOs, but IRQs. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- For the reference. May be applied together with 20240508144741.1270912-1-andriy.shevchenko@linux.intel.com as a precursor. drivers/gpio/gpiolib.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)