From patchwork Thu Feb 8 09:59:02 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartosz Golaszewski X-Patchwork-Id: 1896500 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.a=rsa-sha256 header.s=20230601 header.b=tylBFRuz; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=147.75.199.223; helo=ny.mirrors.kernel.org; envelope-from=linux-gpio+bounces-3072-incoming=patchwork.ozlabs.org@vger.kernel.org; receiver=patchwork.ozlabs.org) Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org [147.75.199.223]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4TVsv06q4Vz23g7 for ; Thu, 8 Feb 2024 21:01:00 +1100 (AEDT) Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 5B1BD1C26A68 for ; Thu, 8 Feb 2024 10:00:58 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 25AD86F090; Thu, 8 Feb 2024 09:59:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="tylBFRuz" X-Original-To: linux-gpio@vger.kernel.org Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 13B5A6D1C7 for ; Thu, 8 Feb 2024 09:59:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707386375; cv=none; b=kR6WVEq9qETko73Y22jxuLDNhH8e19YkdNNx1fbSkkOy1TBZBbbBUv9YErGxKqirbympISDH0uk3zuc38QBwGn0sN53kJfFaH0LgNHabXbzsUXTlt1Zp7zSsCeqni1ti0z2i7ddjm40qWgAP98HXpDexdNEX/0y/1+NPAi/U2SA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707386375; c=relaxed/simple; bh=mlwjr0aacGOVjyJQQ9hj6Ih/Pg/kHJfwwqJwE2q8KBU=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=BpGAsXFtUuZCH+mX3af3xUK7xGzuUqMa6I8KzA9MgMaubrN+g/cMjGr2V365ySzxy6nJZI391FkEBYJqeNxkjbC1hQ5uWxoBoDze7bNVuyBDJAtDF+ZXGB3grr+QvC1B1gP4AXOOVGAX0qXIIzg7/i/x5ZzMepEy0aWBkqxH+wg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=tylBFRuz; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-40fd2f7ef55so3844535e9.0 for ; Thu, 08 Feb 2024 01:59:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1707386372; x=1707991172; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=5qtGEKl9eZhP9SS39ifvqdCChUOXpZpW+8/W/M5yqYc=; b=tylBFRuzHSbUWsTv0e9E9FNZvWie+J0Srf1fJ3/RWJ2I8+Piz5q9QW2uMYDyn+gn4N 13hN6cfpwv0inlzzOKb+CTp0Yc2xkdJOcHxEgWblRleTtsB2WWYPIq/ViA8zQZI/D/E+ qOVutYFCnmz7PopXmLXscCfizKea6RkjIu7PI7SEk3Gi2j0O9Nta/6QAzsH/kUqAmckd 8sUuUlwdpIk5cSoYruLbRHzoaAgNCOmTcZSoUFS7TUSv46PZsMW3ipclOeVrv47cNk/z JpRHvJYvVzKMCbRNQKqGzIu3+DOsZmqkfXB/73MwYGHFtcTacoHT8G5kqT6AgN3iCOM4 VGAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707386372; x=1707991172; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5qtGEKl9eZhP9SS39ifvqdCChUOXpZpW+8/W/M5yqYc=; b=c/eN58ey7IE6Q+F3l8sTm42QR8hihOBsxheQo04Tx8gGWyYr/vsEqWKfP6P6udrAco Ipz4v4by3hJz2M7OG9gbdgvvZFXX7ekeIALAVu6uavOJ7Gs+FJe1GWqVeK9+nKeEkFgM ATZF5gkaJOFkILT8a6dJWR6KfAVdYqkw1953ERcI+BUPGgKxOGnwNbfLyHOEn+k/hTs1 TYv63Yv9gT9S7nv/7GX+xwziDorFfjpmBX5DDOWPIAkMNtDPRCrw2hW9NcI/Cev+pJh5 SbMHu9YF5nWqofLaoMPLe0jAHtgj0YyxdRdX5FtXCqmXpW4ggfKyIbLLFIkiVcshApIa G70Q== X-Gm-Message-State: AOJu0Ywzn14Ed2Gr1N5nMldAFhkrv0HKYk7bNrFEzXpMYhRR+gTv+ETY XMXzw8TQVPIRtwmun5jqq7Gth25VHgJ1HqrPuAYX91vJEsrXr81GIdy/9DMPk3s= X-Google-Smtp-Source: AGHT+IF7xF1sC1zEruEl91ExQYdoLugNN6uIujhqm6wWGiVrarrH3BqhqlibKBwtT7ck2eBr9xIv7Q== X-Received: by 2002:a05:600c:519a:b0:410:1d09:10be with SMTP id fa26-20020a05600c519a00b004101d0910bemr1767956wmb.8.1707386372069; Thu, 08 Feb 2024 01:59:32 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCX3SpTRg+/wyeLk3YyvoNnZTfqs3AZl025KQLmo/ZdCl5S+qlFwDXk5yPhWn29Jks9DaHl2xGg2rCb1mAML2RCd12SPU5nFup02EGJJWEzzOCjKl43uLj4sGdTiI7bWCogDEl5AnUHYucjWeVsnTKbHjEixrlf5/BqZz5Nrc+o5NBpoWJVdX+QS3ogZQnqcW6r0xU1GI538oz+0B4JsDgz4JrHCAIy4RN2mryIk1mE8f4PJzLwORKTgcWdglqS9NJ7Z9DJaHJ+EqcSROwVAFNTfLE+tPZMKDonuuStdtggQYfIaIdl9CCzLdnHZs0xvv4oinXrrcGhGaNOHbK5fNOZQfyfwVJjVHw== Received: from brgl-uxlite.home ([2a01:cb1d:334:ac00:44bd:e160:131:19a4]) by smtp.gmail.com with ESMTPSA id x17-20020a5d60d1000000b0033af5086c2dsm3265963wrt.58.2024.02.08.01.59.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Feb 2024 01:59:31 -0800 (PST) From: Bartosz Golaszewski To: Linus Walleij , Kent Gibson , Alex Elder , Geert Uytterhoeven , "Paul E . McKenney" , Andy Shevchenko , Wolfram Sang Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski Subject: [PATCH v3 06/24] gpio: add SRCU infrastructure to struct gpio_desc Date: Thu, 8 Feb 2024 10:59:02 +0100 Message-Id: <20240208095920.8035-7-brgl@bgdev.pl> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20240208095920.8035-1-brgl@bgdev.pl> References: <20240208095920.8035-1-brgl@bgdev.pl> Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: Bartosz Golaszewski Extend the GPIO descriptor with an SRCU structure in order to serialize the access to the label. Initialize and clean it up where applicable. Signed-off-by: Bartosz Golaszewski Reviewed-by: Linus Walleij --- drivers/gpio/gpiolib.c | 18 ++++++++++++++++-- drivers/gpio/gpiolib.h | 3 +++ 2 files changed, 19 insertions(+), 2 deletions(-) diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c index fbfddc9860fd..b26d39bc3389 100644 --- a/drivers/gpio/gpiolib.c +++ b/drivers/gpio/gpiolib.c @@ -672,6 +672,10 @@ EXPORT_SYMBOL_GPL(gpiochip_line_is_valid); static void gpiodev_release(struct device *dev) { struct gpio_device *gdev = to_gpio_device(dev); + unsigned int i; + + for (i = 0; i < gdev->ngpio; i++) + cleanup_srcu_struct(&gdev->descs[i].srcu); ida_free(&gpio_ida, gdev->id); kfree_const(gdev->label); @@ -836,7 +840,7 @@ int gpiochip_add_data_with_key(struct gpio_chip *gc, void *data, struct lock_class_key *request_key) { struct gpio_device *gdev; - unsigned int i; + unsigned int i, j; int base = 0; int ret = 0; @@ -970,6 +974,13 @@ int gpiochip_add_data_with_key(struct gpio_chip *gc, void *data, for (i = 0; i < gc->ngpio; i++) { struct gpio_desc *desc = &gdev->descs[i]; + ret = init_srcu_struct(&desc->srcu); + if (ret) { + for (j = 0; j < i; j++) + cleanup_srcu_struct(&gdev->descs[j].srcu); + goto err_remove_of_chip; + } + if (gc->get_direction && gpiochip_line_is_valid(gc, i)) { assign_bit(FLAG_IS_OUT, &desc->flags, !gc->get_direction(gc, i)); @@ -981,7 +992,7 @@ int gpiochip_add_data_with_key(struct gpio_chip *gc, void *data, ret = gpiochip_add_pin_ranges(gc); if (ret) - goto err_remove_of_chip; + goto err_cleanup_desc_srcu; acpi_gpiochip_add(gc); @@ -1020,6 +1031,9 @@ int gpiochip_add_data_with_key(struct gpio_chip *gc, void *data, gpiochip_irqchip_free_valid_mask(gc); err_remove_acpi_chip: acpi_gpiochip_remove(gc); +err_cleanup_desc_srcu: + for (i = 0; i < gdev->ngpio; i++) + cleanup_srcu_struct(&gdev->descs[i].srcu); err_remove_of_chip: gpiochip_free_hogs(gc); of_gpiochip_remove(gc); diff --git a/drivers/gpio/gpiolib.h b/drivers/gpio/gpiolib.h index 1058f326fe2b..6e14b629c48b 100644 --- a/drivers/gpio/gpiolib.h +++ b/drivers/gpio/gpiolib.h @@ -17,6 +17,7 @@ #include #include #include +#include #define GPIOCHIP_NAME "gpiochip" @@ -147,6 +148,7 @@ void gpiod_line_state_notify(struct gpio_desc *desc, unsigned long action); * @label: Name of the consumer * @name: Line name * @hog: Pointer to the device node that hogs this line (if any) + * @srcu: SRCU struct protecting the label pointer. * * These are obtained using gpiod_get() and are preferable to the old * integer-based handles. @@ -184,6 +186,7 @@ struct gpio_desc { #ifdef CONFIG_OF_DYNAMIC struct device_node *hog; #endif + struct srcu_struct srcu; }; #define gpiod_not_found(desc) (IS_ERR(desc) && PTR_ERR(desc) == -ENOENT)