[v2] mips: alchemy: gpio: Include the right header

Message ID	20221103101535.715956-1-linus.walleij@linaro.org
State	New
Headers	show Return-Path: <linux-gpio-owner@vger.kernel.org> From: Linus Walleij <linus.walleij@linaro.org> To: Thomas Bogendoerfer <tsbogend@alpha.franken.de> Cc: linux-mips@vger.kernel.org, Linus Walleij <linus.walleij@linaro.org>, Bartosz Golaszewski <brgl@bgdev.pl>, linux-gpio@vger.kernel.org, =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org> Subject: [PATCH v2] mips: alchemy: gpio: Include the right header Date: Thu, 3 Nov 2022 11:15:35 +0100 Message-Id: <20221103101535.715956-1-linus.walleij@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk
Series	[v2] mips: alchemy: gpio: Include the right header \| expand [v2] mips: alchemy: gpio: Include the right header

Message ID

20221103101535.715956-1-linus.walleij@linaro.org

State

New

Headers

From: Linus Walleij <linus.walleij@linaro.org>
To: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc: linux-mips@vger.kernel.org, Linus Walleij <linus.walleij@linaro.org>,
 Bartosz Golaszewski <brgl@bgdev.pl>, linux-gpio@vger.kernel.org,
	=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>
Subject: [PATCH v2] mips: alchemy: gpio: Include the right header
Date: Thu,  3 Nov 2022 11:15:35 +0100
Message-Id: <20221103101535.715956-1-linus.walleij@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk

Series

[v2] mips: alchemy: gpio: Include the right header | expand

Commit Message

Linus Walleij Nov. 3, 2022, 10:15 a.m. UTC

The local GPIO driver in the MIPS Alchemy is including the legacy
<linux/gpio.h> header but what it wants is to implement a GPIO
driver so include <linux/gpio/driver.h> instead.

Cc: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: linux-gpio@vger.kernel.org
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
ChangeLog v1->v2:
- Collect Philippe's review tag
- Resend to the right MIPS maintainer
---
 arch/mips/alchemy/common/gpiolib.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Thomas Bogendoerfer Nov. 11, 2022, 3:04 p.m. UTC | #1

On Thu, Nov 03, 2022 at 11:15:35AM +0100, Linus Walleij wrote:
> The local GPIO driver in the MIPS Alchemy is including the legacy
> <linux/gpio.h> header but what it wants is to implement a GPIO
> driver so include <linux/gpio/driver.h> instead.
> 
> Cc: Bartosz Golaszewski <brgl@bgdev.pl>
> Cc: linux-gpio@vger.kernel.org
> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> ChangeLog v1->v2:
> - Collect Philippe's review tag
> - Resend to the right MIPS maintainer
> ---
>  arch/mips/alchemy/common/gpiolib.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/mips/alchemy/common/gpiolib.c b/arch/mips/alchemy/common/gpiolib.c
> index a17d7a8909c4..1b16daaa86ae 100644
> --- a/arch/mips/alchemy/common/gpiolib.c
> +++ b/arch/mips/alchemy/common/gpiolib.c
> @@ -31,7 +31,7 @@
>  #include <linux/init.h>
>  #include <linux/kernel.h>
>  #include <linux/types.h>
> -#include <linux/gpio.h>
> +#include <linux/gpio/driver.h>
>  #include <asm/mach-au1x00/gpio-au1000.h>
>  #include <asm/mach-au1x00/gpio-au1300.h>
>  
> -- 
> 2.34.1

applied to mips-fixes.

Thomas.

diff --git a/arch/mips/alchemy/common/gpiolib.c b/arch/mips/alchemy/common/gpiolib.c
index a17d7a8909c4..1b16daaa86ae 100644
--- a/arch/mips/alchemy/common/gpiolib.c
+++ b/arch/mips/alchemy/common/gpiolib.c
@@ -31,7 +31,7 @@ 
 #include <linux/init.h>
 #include <linux/kernel.h>
 #include <linux/types.h>
-#include <linux/gpio.h>
+#include <linux/gpio/driver.h>
 #include <asm/mach-au1x00/gpio-au1000.h>
 #include <asm/mach-au1x00/gpio-au1300.h>

[v2] mips: alchemy: gpio: Include the right header

Commit Message

Comments

Patch