diff mbox series

[v3,12/17] dt-bindings: pinctrl: qcom,sm8250: use common TLMM pin schema

Message ID 20221016172212.49105-13-krzysztof.kozlowski@linaro.org
State New
Headers show
Series pinctrl/arm64: qcom: 4th set of Qualcomm TLMM pinctrl schema warnings | expand

Commit Message

Krzysztof Kozlowski Oct. 16, 2022, 5:22 p.m. UTC 
The common Qualcomm TLMM pin controller schema for pin mux and config
already brings requirement of function for gpio pins and the definition
of drive-strength.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Acked-by: Rob Herring <robh@kernel.org>
Reviewed-by: Bjorn Andersson <andersson@kernel.org>

---

Changes since v2:
1. Drop drive-strength, reword commit msg.
2. Add tags.
---
 .../bindings/pinctrl/qcom,sm8250-pinctrl.yaml | 19 ++-----------------
 1 file changed, 2 insertions(+), 17 deletions(-)

Comments

Krzysztof Kozlowski Oct. 18, 2022, 3:49 p.m. UTC | #1 
On Sun, 16 Oct 2022 13:22:07 -0400, Krzysztof Kozlowski wrote:
> The common Qualcomm TLMM pin controller schema for pin mux and config
> already brings requirement of function for gpio pins and the definition
> of drive-strength.
> 
> 

Applied, thanks!

[12/17] dt-bindings: pinctrl: qcom,sm8250: use common TLMM pin schema
        https://git.kernel.org/krzk/linux-dt/c/fd69e8befa1cbf29435b0666320d5f8848e8b333

Best regards,
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sm8250-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sm8250-pinctrl.yaml
index d7d8e5d3b659..9447b79655e2 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,sm8250-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,sm8250-pinctrl.yaml
@@ -64,6 +64,7 @@  patternProperties:
     if:
       type: object
     then:
+      $ref: qcom,tlmm-common.yaml#/$defs/qcom-tlmm-state
       properties:
         pins:
           description:
@@ -99,18 +100,12 @@  patternProperties:
                   tsif0_en, tsif0_error, tsif0_sync, tsif1_clk, tsif1_data, tsif1_en,
                   tsif1_error, tsif1_sync, usb2phy_ac, usb_phy, vsense_trigger ]
 
-        drive-strength:
-          enum: [2, 4, 6, 8, 10, 12, 14, 16]
-          default: 2
-          description:
-            Selects the drive strength for the specified pins, in mA.
-
         bias-pull-down: true
 
         bias-pull-up: true
 
         bias-disable: true
-
+        drive-strength: true
         output-high: true
 
         output-low: true
@@ -118,16 +113,6 @@  patternProperties:
       required:
         - pins
 
-      allOf:
-        - $ref: "qcom,tlmm-common.yaml#/$defs/qcom-tlmm-state"
-        - if:
-            properties:
-              pins:
-                pattern: "^gpio([0-9]|[1-9][0-9]|1[0-7][0-9])$"
-          then:
-            required:
-              - function
-
       additionalProperties: false
 
 allOf: