| Message ID | 20211012153945.2651412-4-u.kleine-koenig@pengutronix.de |
|---|---|
| State | New |
| Headers | show |
| Series | Make some spi device drivers return zero in .remove() | expand |
On Tue, Oct 12, 2021 at 5:39 PM Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote: > > An spi remove callback is only called for devices that probed > successfully. In this case this implies that mc33880_probe() set a > non-NULL driver data. So the check for mc being NULL is never true and > the check can be dropped. > > Also the return value ofspi remove callbacks is ignored anyway. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > --- > drivers/gpio/gpio-mc33880.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/gpio/gpio-mc33880.c b/drivers/gpio/gpio-mc33880.c > index f8194f7c6186..31d2be1bebc8 100644 > --- a/drivers/gpio/gpio-mc33880.c > +++ b/drivers/gpio/gpio-mc33880.c > @@ -139,8 +139,6 @@ static int mc33880_remove(struct spi_device *spi) > struct mc33880 *mc; > > mc = spi_get_drvdata(spi); > - if (!mc) > - return -ENODEV; > > gpiochip_remove(&mc->chip); > mutex_destroy(&mc->lock); > -- > 2.30.2 > Applied, thanks! Bart
diff --git a/drivers/gpio/gpio-mc33880.c b/drivers/gpio/gpio-mc33880.c index f8194f7c6186..31d2be1bebc8 100644 --- a/drivers/gpio/gpio-mc33880.c +++ b/drivers/gpio/gpio-mc33880.c @@ -139,8 +139,6 @@ static int mc33880_remove(struct spi_device *spi) struct mc33880 *mc; mc = spi_get_drvdata(spi); - if (!mc) - return -ENODEV; gpiochip_remove(&mc->chip); mutex_destroy(&mc->lock);
An spi remove callback is only called for devices that probed successfully. In this case this implies that mc33880_probe() set a non-NULL driver data. So the check for mc being NULL is never true and the check can be dropped. Also the return value ofspi remove callbacks is ignored anyway. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> --- drivers/gpio/gpio-mc33880.c | 2 -- 1 file changed, 2 deletions(-)