From patchwork Sat Jul 18 21:26:08 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 1331618 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-gpio-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4B8Ldg3Wc0z9sQt for ; Sun, 19 Jul 2020 07:26:15 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728098AbgGRV0M (ORCPT ); Sat, 18 Jul 2020 17:26:12 -0400 Received: from mga01.intel.com ([192.55.52.88]:30320 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726933AbgGRV0M (ORCPT ); Sat, 18 Jul 2020 17:26:12 -0400 IronPort-SDR: MBRW0FrZdvgbgO+lXmaC+dBJxkg+fisjKvmn/zQjdmobSGzk26gzicUQhvdLK/3DEQONQFD3AZ d4dnq3Eby3bg== X-IronPort-AV: E=McAfee;i="6000,8403,9686"; a="167899647" X-IronPort-AV: E=Sophos;i="5.75,368,1589266800"; d="scan'208";a="167899647" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jul 2020 14:26:11 -0700 IronPort-SDR: GHR4Ks4HxFYA3EleADq2CGMUrDcRMIkwpBCr6KSxzPdKRGWSCEjF82OlC8gbfXQxDcp3RWYuQW tj4YcaHVxFoQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,368,1589266800"; d="scan'208";a="269801007" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga007.fm.intel.com with ESMTP; 18 Jul 2020 14:26:10 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id 9CD4C924; Sun, 19 Jul 2020 00:26:09 +0300 (EEST) From: Andy Shevchenko To: Linus Walleij , Bartosz Golaszewski , linux-gpio@vger.kernel.org, Geert Uytterhoeven Cc: Andy Shevchenko Subject: [PATCH v1 3/3] gpio: aggregator: Assign name and offsets only once in a loop Date: Sun, 19 Jul 2020 00:26:08 +0300 Message-Id: <20200718212608.65328-4-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200718212608.65328-1-andriy.shevchenko@linux.intel.com> References: <20200718212608.65328-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org The for-loop looks a bit hard to read when we extract two arguments per iteration. The 'do {} while (true)' makes it easier to read despite being infinite loop. Signed-off-by: Andy Shevchenko --- drivers/gpio/gpio-aggregator.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/gpio/gpio-aggregator.c b/drivers/gpio/gpio-aggregator.c index de9ae622ca23..962ec9373d6f 100644 --- a/drivers/gpio/gpio-aggregator.c +++ b/drivers/gpio/gpio-aggregator.c @@ -109,14 +109,17 @@ static int aggr_parse(struct gpio_aggregator *aggr) if (!bitmap) return -ENOMEM; - for (name = get_arg(&args), offsets = get_arg(&args); name; - offsets = get_arg(&args)) { + do { + name = get_arg(&args); + if (!name) + break; if (IS_ERR(name)) { pr_err("Cannot get GPIO specifier: %pe\n", name); error = PTR_ERR(name); goto free_bitmap; } + offsets = get_arg(&args); if (!isrange(offsets)) { /* Named GPIO line */ error = aggr_add_gpio(aggr, name, U16_MAX, &n); @@ -139,9 +142,7 @@ static int aggr_parse(struct gpio_aggregator *aggr) if (error) goto free_bitmap; } - - name = get_arg(&args); - } + } while (true); if (!n) { pr_err("No GPIOs specified\n");