Message ID | 20200623040107.22270-8-warthog618@gmail.com |
---|---|
State | New |
Headers | show |
Series | gpio: cdev: add uAPI V2 | expand |
wt., 23 cze 2020 o 06:02 Kent Gibson <warthog618@gmail.com> napisaĆ(a): > > Remove pointless decrement of variable, and associated comment. > > While i is used subsequently, it is re-initialized so this decrement > serves no purpose. > > Signed-off-by: Kent Gibson <warthog618@gmail.com> > Reviewed-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
diff --git a/drivers/gpio/gpiolib-cdev.c b/drivers/gpio/gpiolib-cdev.c index b39e7ef8c0d4..d50339ef6f05 100644 --- a/drivers/gpio/gpiolib-cdev.c +++ b/drivers/gpio/gpiolib-cdev.c @@ -331,8 +331,6 @@ static int linehandle_create(struct gpio_device *gdev, void __user *ip) dev_dbg(&gdev->dev, "registered chardev handle for line %d\n", offset); } - /* Let i point at the last handle */ - i--; lh->num_descs = handlereq.lines; fd = get_unused_fd_flags(O_RDONLY | O_CLOEXEC);
Remove pointless decrement of variable, and associated comment. While i is used subsequently, it is re-initialized so this decrement serves no purpose. Signed-off-by: Kent Gibson <warthog618@gmail.com> --- drivers/gpio/gpiolib-cdev.c | 2 -- 1 file changed, 2 deletions(-)