| Message ID | 20200512182721.55127-1-andriy.shevchenko@linux.intel.com |
|---|---|
| State | New |
| Headers | show |
| Series | [v1,1/3] gpio: xgene-sb: Drop redundant OF_GPIO dependency | expand |
On Tue, May 12, 2020 at 8:27 PM Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > There is nothing in the driver requires OF_GPIO. Moreover, driver > supports ACPI and OF_GPIO may be a quite overhead on such configurations. > > Drop dependency for good and replace of_gpio.h to of.h since we have > one function to be defined from there. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Patch applied. Yours, Linus Walleij
diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig index 8ef2179fb9991b..739f179e28b184 100644 --- a/drivers/gpio/Kconfig +++ b/drivers/gpio/Kconfig @@ -638,7 +638,7 @@ config GPIO_XGENE config GPIO_XGENE_SB tristate "APM X-Gene GPIO standby controller support" - depends on ARCH_XGENE && OF_GPIO + depends on ARCH_XGENE select GPIO_GENERIC select GPIOLIB_IRQCHIP select IRQ_DOMAIN_HIERARCHY diff --git a/drivers/gpio/gpio-xgene-sb.c b/drivers/gpio/gpio-xgene-sb.c index b45bfa9baa26c5..203a268dd09c52 100644 --- a/drivers/gpio/gpio-xgene-sb.c +++ b/drivers/gpio/gpio-xgene-sb.c @@ -10,8 +10,8 @@ #include <linux/module.h> #include <linux/io.h> +#include <linux/of.h> #include <linux/platform_device.h> -#include <linux/of_gpio.h> #include <linux/gpio/driver.h> #include <linux/acpi.h>
There is nothing in the driver requires OF_GPIO. Moreover, driver supports ACPI and OF_GPIO may be a quite overhead on such configurations. Drop dependency for good and replace of_gpio.h to of.h since we have one function to be defined from there. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- drivers/gpio/Kconfig | 2 +- drivers/gpio/gpio-xgene-sb.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)