| Message ID | 20200302094317.79002-1-andriy.shevchenko@linux.intel.com |
|---|---|
| State | New |
| Headers | show |
| Series | [v1] gpiolib: Fix wrong appearance of critical message in gpiochip_remove() | expand |
diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c index ea2d05cfb5eb..1f986ba3502a 100644 --- a/drivers/gpio/gpiolib.c +++ b/drivers/gpio/gpiolib.c @@ -1846,7 +1846,7 @@ void gpiochip_remove(struct gpio_chip *chip) } spin_unlock_irqrestore(&gpio_lock, flags); - if (i == gdev->ngpio) + if (i < gdev->ngpio) dev_crit(&gdev->dev, "REMOVING GPIOCHIP WITH GPIOS STILL REQUESTED\n");
When the commit 869233f81337 ("gpiolib: Optimize gpiochip_remove() when check for requested line") refactored a for-loop, the condition to check if we found requested line was mistakenly inverted. So, fix the condition to avoid critical message when it's not supposed to be printed. Fixes: 869233f81337 ("gpiolib: Optimize gpiochip_remove() when check for requested line") Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- drivers/gpio/gpiolib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)