Message ID | 20200108121117.45060-1-yuehaibing@huawei.com |
---|---|
State | New |
Headers | show |
Series | [-next] gpiolib: remove set but not used variable 'config' | expand |
śr., 8 sty 2020 o 13:11 YueHaibing <yuehaibing@huawei.com> napisał(a): > > drivers/gpio/gpiolib.c: In function gpio_set_config: > drivers/gpio/gpiolib.c:3053:16: warning: > variable config set but not used [-Wunused-but-set-variable] > > commit d90f36851d65 ("gpiolib: have a single place > of calling set_config()") left behind this unused variable. > > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: YueHaibing <yuehaibing@huawei.com> > --- > drivers/gpio/gpiolib.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c > index 9fd2dfb..aabf801 100644 > --- a/drivers/gpio/gpiolib.c > +++ b/drivers/gpio/gpiolib.c > @@ -3050,7 +3050,6 @@ static int gpio_do_set_config(struct gpio_chip *gc, unsigned int offset, > static int gpio_set_config(struct gpio_chip *gc, unsigned int offset, > enum pin_config_param mode) > { > - unsigned long config; > unsigned arg; > > switch (mode) { > @@ -3064,7 +3063,6 @@ static int gpio_set_config(struct gpio_chip *gc, unsigned int offset, > arg = 0; > } > > - config = PIN_CONF_PACKED(mode, arg); > return gpio_do_set_config(gc, offset, mode); > } > Reviewed-by: Bartosz Golaszewski <bgolaszewski@baylibre.com> Thanks!
On Wed, Jan 8, 2020 at 1:11 PM YueHaibing <yuehaibing@huawei.com> wrote: > drivers/gpio/gpiolib.c: In function gpio_set_config: > drivers/gpio/gpiolib.c:3053:16: warning: > variable config set but not used [-Wunused-but-set-variable] > > commit d90f36851d65 ("gpiolib: have a single place > of calling set_config()") left behind this unused variable. > > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: YueHaibing <yuehaibing@huawei.com> Patch applied with Bartosz' review tag. Yours, Linus Walleij
diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c index 9fd2dfb..aabf801 100644 --- a/drivers/gpio/gpiolib.c +++ b/drivers/gpio/gpiolib.c @@ -3050,7 +3050,6 @@ static int gpio_do_set_config(struct gpio_chip *gc, unsigned int offset, static int gpio_set_config(struct gpio_chip *gc, unsigned int offset, enum pin_config_param mode) { - unsigned long config; unsigned arg; switch (mode) { @@ -3064,7 +3063,6 @@ static int gpio_set_config(struct gpio_chip *gc, unsigned int offset, arg = 0; } - config = PIN_CONF_PACKED(mode, arg); return gpio_do_set_config(gc, offset, mode); }
drivers/gpio/gpiolib.c: In function gpio_set_config: drivers/gpio/gpiolib.c:3053:16: warning: variable config set but not used [-Wunused-but-set-variable] commit d90f36851d65 ("gpiolib: have a single place of calling set_config()") left behind this unused variable. Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: YueHaibing <yuehaibing@huawei.com> --- drivers/gpio/gpiolib.c | 2 -- 1 file changed, 2 deletions(-)