[v1,04/10] gpio: crystalcove: Sort headers alphabetically

Message ID	20190205133829.68968-4-andriy.shevchenko@linux.intel.com
State	New
Headers	show Return-Path: <linux-gpio-owner@vger.kernel.org> From: Andy Shevchenko <andriy.shevchenko@linux.intel.com> To: Linus Walleij <linus.walleij@linaro.org>, Bartosz Golaszewski <bgolaszewski@baylibre.com>, linux-gpio@vger.kernel.org, Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com> Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Subject: [PATCH v1 04/10] gpio: crystalcove: Sort headers alphabetically Date: Tue, 5 Feb 2019 15:38:23 +0200 Message-Id: <20190205133829.68968-4-andriy.shevchenko@linux.intel.com> In-Reply-To: <20190205133829.68968-1-andriy.shevchenko@linux.intel.com> References: <20190205133829.68968-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk
Series	[v1,01/10] gpio: crystalcove: Use for_each_set_bit() in IRQ handler \| expand [v1,01/10] gpio: crystalcove: Use for_each_set_bit() in IRQ handler [v1,02/10] gpio: wcove: Allow return negative error code from to_reg() [v1,03/10] gpio: msic: Remove duplicate check in IRQ handler [v1,04/10] gpio: crystalcove: Sort headers alphabetically [v1,05/10] gpio: msic: Sort headers alphabetically [v1,06/10] gpio: wcove: Sort headers alphabetically [v1,07/10] gpio: wcove: Fix indentation [v1,08/10] gpio: crystalcove: Convert to use SPDX identifier [v1,09/10] gpio: msic: Convert to use SPDX identifier [v1,10/10] gpio: wcove: Convert to use SPDX identifier

Message ID

20190205133829.68968-4-andriy.shevchenko@linux.intel.com

State

New

Headers

From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Linus Walleij <linus.walleij@linaro.org>,
	Bartosz Golaszewski <bgolaszewski@baylibre.com>,
	linux-gpio@vger.kernel.org, Kuppuswamy Sathyanarayanan 
	<sathyanarayanan.kuppuswamy@linux.intel.com>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: [PATCH v1 04/10] gpio: crystalcove: Sort headers alphabetically
Date: Tue,  5 Feb 2019 15:38:23 +0200
Message-Id: <20190205133829.68968-4-andriy.shevchenko@linux.intel.com>
In-Reply-To: <20190205133829.68968-1-andriy.shevchenko@linux.intel.com>
References: <20190205133829.68968-1-andriy.shevchenko@linux.intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-gpio-owner@vger.kernel.org
Precedence: bulk

Series

[v1,01/10] gpio: crystalcove: Use for_each_set_bit() in IRQ handler | expand

Sort header block alphabetically for easy maintenance. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- drivers/gpio/gpio-crystalcove.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)

Comments

Kuppuswamy Sathyanarayanan Feb. 5, 2019, 6:59 p.m. UTC | #1

On 2/5/19 5:38 AM, Andy Shevchenko wrote:
> Sort header block alphabetically for easy maintenance.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Looks good to me.

Reviewed-by: Kuppuswamy Sathyanarayanan 
<sathyanarayanan.kuppuswamy@linux.intel.com>

> ---
>   drivers/gpio/gpio-crystalcove.c | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpio/gpio-crystalcove.c b/drivers/gpio/gpio-crystalcove.c
> index 3c39d1b6c3ad..c73e7c285636 100644
> --- a/drivers/gpio/gpio-crystalcove.c
> +++ b/drivers/gpio/gpio-crystalcove.c
> @@ -15,14 +15,14 @@
>    * Author: Yang, Bin <bin.yang@intel.com>
>    */
>   
> +#include <linux/bitops.h>
> +#include <linux/gpio/driver.h>
>   #include <linux/interrupt.h>
> +#include <linux/mfd/intel_soc_pmic.h>
>   #include <linux/module.h>
>   #include <linux/platform_device.h>
> -#include <linux/gpio/driver.h>
> -#include <linux/seq_file.h>
> -#include <linux/bitops.h>
>   #include <linux/regmap.h>
> -#include <linux/mfd/intel_soc_pmic.h>
> +#include <linux/seq_file.h>
>   
>   #define CRYSTALCOVE_GPIO_NUM	16
>   #define CRYSTALCOVE_VGPIO_NUM	95

diff --git a/drivers/gpio/gpio-crystalcove.c b/drivers/gpio/gpio-crystalcove.c
index 3c39d1b6c3ad..c73e7c285636 100644
--- a/drivers/gpio/gpio-crystalcove.c
+++ b/drivers/gpio/gpio-crystalcove.c
@@ -15,14 +15,14 @@ 
  * Author: Yang, Bin <bin.yang@intel.com>
  */
 
+#include <linux/bitops.h>
+#include <linux/gpio/driver.h>
 #include <linux/interrupt.h>
+#include <linux/mfd/intel_soc_pmic.h>
 #include <linux/module.h>
 #include <linux/platform_device.h>
-#include <linux/gpio/driver.h>
-#include <linux/seq_file.h>
-#include <linux/bitops.h>
 #include <linux/regmap.h>
-#include <linux/mfd/intel_soc_pmic.h>
+#include <linux/seq_file.h>
 
 #define CRYSTALCOVE_GPIO_NUM	16
 #define CRYSTALCOVE_VGPIO_NUM	95

[v1,04/10] gpio: crystalcove: Sort headers alphabetically

Commit Message

Comments

Patch