From patchwork Sat Dec 29 12:57:11 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Martin Blumenstingl X-Patchwork-Id: 1019349 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-gpio-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=googlemail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=googlemail.com header.i=@googlemail.com header.b="uwIjXHkD"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 43RkBY4YhJz9s55 for ; Sat, 29 Dec 2018 23:57:41 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726072AbeL2M5j (ORCPT ); Sat, 29 Dec 2018 07:57:39 -0500 Received: from mail-wm1-f65.google.com ([209.85.128.65]:34471 "EHLO mail-wm1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726032AbeL2M5j (ORCPT ); Sat, 29 Dec 2018 07:57:39 -0500 Received: by mail-wm1-f65.google.com with SMTP id y185so27442506wmd.1; Sat, 29 Dec 2018 04:57:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=0GgHqqxZVFXgmfbHJtxlutcHlK9nbAzoBbUIQBCbANI=; b=uwIjXHkDkkPZPetAQRlQ8Dx0nMlgoymY6ulxb1HBCaPhu8NTZtSOApAgBwpRh19a/1 bJbenQV6tpB8P8pR6L9vBsubpz0wWKquymP9F3fi7i7ljO4b3qjd/Gj/PjCPao5HNaH8 DYKyhBrVS7m5m9egGQZWVop04jtTnopuEsKIJpJLRgtvUoK7FmHfu1Thk7FodE1b/6f8 1AOVC6YL/0GSrugej4VjDM4F7gTdQseqG1gRXPEs1cUOWQyjGDokJJy/fPDrMVLaaGFS jSegRpMHu3+5vF7o2irUWR4wxk25ZbhoH5O86aobJsYfQdVsqLPB72wudis5HEm3RXWg cHUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=0GgHqqxZVFXgmfbHJtxlutcHlK9nbAzoBbUIQBCbANI=; b=RsavJuqeCgXrx6QZgRcXK+TJ2Uq/bjoPgycWc2aB2ru6eBaoFe27cjgX69OWoii8qK z/gnkrZh2Bsd7zZmyXNFKLwCMqWsEck9eITJd2eWJpPC6lLSF21IEeQzoAi7uzXMkK3w zyk+Nr2GFlhOq11BCib0ea5KLxXIf1eQfYR+8mUwr7zir9C0ysPrH+D4q+5EenMDTOTo v5OtmhM5zs0Sy8Lm7mR9xUgFRWpy7RKht1865Rp2bbm+XFCj7HvNR5fwOO6rW4lT0R+2 D8trzn+hP5vKoUHgm8jHeZ8e30wkwMHLLuFYHmu2B1onC47wu0o/qO0DH5jvMybssU5p tpIw== X-Gm-Message-State: AJcUukeT9UDJCjZzq2XVwxVEajsOBSCDgkIQSO0nypFyb1k2Cdadqfyt k+tx7CJG6fiyNsQ1b/Gq7Mk= X-Google-Smtp-Source: AFSGD/Xq2dNuPD5B9Jyeeixk2jL9dKx4017uH/Ni5DQpYTDxU0ptgJE384Bv+wvOFtev/8VZrZfeOg== X-Received: by 2002:a1c:5fd7:: with SMTP id t206mr28045169wmb.145.1546088256856; Sat, 29 Dec 2018 04:57:36 -0800 (PST) Received: from blackbox.darklights.net (p200300DCD7294600914F24DE1716D3FC.dip0.t-ipconnect.de. [2003:dc:d729:4600:914f:24de:1716:d3fc]) by smtp.googlemail.com with ESMTPSA id h17sm31987059wrt.59.2018.12.29.04.57.35 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 29 Dec 2018 04:57:36 -0800 (PST) From: Martin Blumenstingl To: linux-amlogic@lists.infradead.org, khilman@baylibre.com, linus.walleij@linaro.org Cc: linux-mmc@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linus.luessing@c0d3.blue, balbes-150@yandex.ru, linux@roeck-us.net, bgolaszewski@baylibre.com, Martin Blumenstingl Subject: [PATCH 3/3] ARM: dts: meson8m2: mxiii-plus: mark the SD card detection GPIO active-low Date: Sat, 29 Dec 2018 13:57:11 +0100 Message-Id: <20181229125711.5205-4-martin.blumenstingl@googlemail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20181229125711.5205-1-martin.blumenstingl@googlemail.com> References: <20181229125711.5205-1-martin.blumenstingl@googlemail.com> MIME-Version: 1.0 Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org After commit 89a5e15bcba87d ("gpio/mmc/of: Respect polarity in the device tree") SD cards are not detected anymore. The CD GPIO is "active low" on the MXIII-Plus. The MMC dt-bindings specify: "[...] using the "cd-inverted" property means, that the CD line is active high, i.e. it is high, when a card is inserted". Fix the description of the SD card by marking it as GPIO_ACTIVE_LOW and drop the "cd-inverted" property. This makes the definition consistent with the existing dt-bindings and fixes the check whether an SD card is inserted. Fixes: 35ee52bea66c74 ("ARM: dts: meson8m2: add support for the Tronsmart MXIII Plus") Signed-off-by: Martin Blumenstingl Reviewed-by: Linus Walleij --- arch/arm/boot/dts/meson8m2-mxiii-plus.dts | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/meson8m2-mxiii-plus.dts b/arch/arm/boot/dts/meson8m2-mxiii-plus.dts index f5853610b20b..6ac02beb5fa7 100644 --- a/arch/arm/boot/dts/meson8m2-mxiii-plus.dts +++ b/arch/arm/boot/dts/meson8m2-mxiii-plus.dts @@ -206,8 +206,7 @@ cap-sd-highspeed; disable-wp; - cd-gpios = <&gpio CARD_6 GPIO_ACTIVE_HIGH>; - cd-inverted; + cd-gpios = <&gpio CARD_6 GPIO_ACTIVE_LOW>; vmmc-supply = <&vcc_3v3>; };