| Message ID | 20181229125711.5205-4-martin.blumenstingl@googlemail.com |
|---|---|
| State | New |
| Headers | show |
| Series | ARM: dts: meson: fix SD card cd-gpio (pre v4.21-rc) | expand |
On Sat, Dec 29, 2018 at 1:57 PM Martin Blumenstingl <martin.blumenstingl@googlemail.com> wrote: > After commit 89a5e15bcba87d ("gpio/mmc/of: Respect polarity in the device > tree") SD cards are not detected anymore. > > The CD GPIO is "active low" on the MXIII-Plus. The MMC dt-bindings > specify: "[...] using the "cd-inverted" property means, that the CD line > is active high, i.e. it is high, when a card is inserted". > > Fix the description of the SD card by marking it as GPIO_ACTIVE_LOW and > drop the "cd-inverted" property. This makes the definition consistent > with the existing dt-bindings and fixes the check whether an SD card is > inserted. > > Fixes: 35ee52bea66c74 ("ARM: dts: meson8m2: add support for the Tronsmart MXIII Plus") > Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij
diff --git a/arch/arm/boot/dts/meson8m2-mxiii-plus.dts b/arch/arm/boot/dts/meson8m2-mxiii-plus.dts index f5853610b20b..6ac02beb5fa7 100644 --- a/arch/arm/boot/dts/meson8m2-mxiii-plus.dts +++ b/arch/arm/boot/dts/meson8m2-mxiii-plus.dts @@ -206,8 +206,7 @@ cap-sd-highspeed; disable-wp; - cd-gpios = <&gpio CARD_6 GPIO_ACTIVE_HIGH>; - cd-inverted; + cd-gpios = <&gpio CARD_6 GPIO_ACTIVE_LOW>; vmmc-supply = <&vcc_3v3>; };
After commit 89a5e15bcba87d ("gpio/mmc/of: Respect polarity in the device tree") SD cards are not detected anymore. The CD GPIO is "active low" on the MXIII-Plus. The MMC dt-bindings specify: "[...] using the "cd-inverted" property means, that the CD line is active high, i.e. it is high, when a card is inserted". Fix the description of the SD card by marking it as GPIO_ACTIVE_LOW and drop the "cd-inverted" property. This makes the definition consistent with the existing dt-bindings and fixes the check whether an SD card is inserted. Fixes: 35ee52bea66c74 ("ARM: dts: meson8m2: add support for the Tronsmart MXIII Plus") Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> --- arch/arm/boot/dts/meson8m2-mxiii-plus.dts | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)