| Message ID | 20181210165005.27965-1-nsaenzjulienne@suse.de |
|---|---|
| State | New |
| Headers | show |
| Series | gpio: raspberrypi-exp: decrease refcount on firmware dt node | expand |
On Mon, Dec 10, 2018 at 5:50 PM Nicolas Saenz Julienne <nsaenzjulienne@suse.de> wrote: > We're getting a reference RPi's firmware node in order to be able to > communicate with it's driver. We should decrease the reference count on > the dt node after being done with it. > > Fixes: a98d90e7d588 ("gpio: raspberrypi-exp: Driver for RPi3 GPIO expander via mailbox service") > Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de> Patch applied. Yours, Linus Walleij
diff --git a/drivers/gpio/gpio-raspberrypi-exp.c b/drivers/gpio/gpio-raspberrypi-exp.c index d6d36d537e37..b77ea16ffa03 100644 --- a/drivers/gpio/gpio-raspberrypi-exp.c +++ b/drivers/gpio/gpio-raspberrypi-exp.c @@ -206,6 +206,7 @@ static int rpi_exp_gpio_probe(struct platform_device *pdev) } fw = rpi_firmware_get(fw_node); + of_node_put(fw_node); if (!fw) return -EPROBE_DEFER;
We're getting a reference RPi's firmware node in order to be able to communicate with it's driver. We should decrease the reference count on the dt node after being done with it. Fixes: a98d90e7d588 ("gpio: raspberrypi-exp: Driver for RPi3 GPIO expander via mailbox service") Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de> --- drivers/gpio/gpio-raspberrypi-exp.c | 1 + 1 file changed, 1 insertion(+)