diff mbox series

[v1,11/26] gpio: pch: Remove redundant __func__ from debug print

Message ID 20181129145716.62065-12-andriy.shevchenko@linux.intel.com
State New
Headers show
Series gpio: Clean up Intel GPIO drivers | expand

Commit Message

Andy Shevchenko Nov. 29, 2018, 2:57 p.m. UTC
dev_dbg includes the function name & line number by default when dynamic
debugging is enabled. Hence__func__ is reduntant here and removed.

Do the same for any messages in ->probe() since it doesn't make sense.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/gpio/gpio-pch.c | 11 ++++-------
 1 file changed, 4 insertions(+), 7 deletions(-)
diff mbox series

Patch

diff --git a/drivers/gpio/gpio-pch.c b/drivers/gpio/gpio-pch.c
index 0c9032d6bf70..ba5199c681df 100644
--- a/drivers/gpio/gpio-pch.c
+++ b/drivers/gpio/gpio-pch.c
@@ -248,8 +248,7 @@  static int pch_irq_type(struct irq_data *d, unsigned int type)
 		im_reg = &chip->reg->im1;
 		im_pos = ch - 8;
 	}
-	dev_dbg(chip->dev, "%s:irq=%d type=%d ch=%d pos=%d\n",
-		__func__, irq, type, ch, im_pos);
+	dev_dbg(chip->dev, "irq=%d type=%d ch=%d pos=%d\n", irq, type, ch, im_pos);
 
 	spin_lock_irqsave(&chip->spinlock, flags);
 
@@ -319,8 +318,7 @@  static irqreturn_t pch_gpio_handler(int irq, void *dev_id)
 	int i, ret = IRQ_NONE;
 
 	for_each_set_bit(i, &reg_val, gpio_pins[chip->ioh]) {
-		dev_dbg(chip->dev, "%s:[%d]:irq=%d  status=0x%x\n", __func__,
-			i, irq, reg_val);
+		dev_dbg(chip->dev, "[%d]:irq=%d  status=0x%x\n", i, irq, reg_val);
 		generic_handle_irq(chip->irq_base + i);
 		ret = IRQ_HANDLED;
 	}
@@ -370,7 +368,7 @@  static int pch_gpio_probe(struct pci_dev *pdev,
 	chip->dev = &pdev->dev;
 	ret = pcim_enable_device(pdev);
 	if (ret) {
-		dev_err(&pdev->dev, "%s : pci_enable_device FAILED", __func__);
+		dev_err(&pdev->dev, "pci_enable_device FAILED");
 		return ret;
 	}
 
@@ -419,8 +417,7 @@  static int pch_gpio_probe(struct pci_dev *pdev,
 	ret = devm_request_irq(&pdev->dev, pdev->irq, pch_gpio_handler,
 			       IRQF_SHARED, KBUILD_MODNAME, chip);
 	if (ret) {
-		dev_err(&pdev->dev,
-			"%s request_irq failed\n", __func__);
+		dev_err(&pdev->dev, "request_irq failed\n");
 		return ret;
 	}