From patchwork Wed Apr 26 15:05:39 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Colin Ian King X-Patchwork-Id: 755524 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3wCkN357WCz9sCZ for ; Thu, 27 Apr 2017 01:22:27 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751635AbdDZPS3 (ORCPT ); Wed, 26 Apr 2017 11:18:29 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:36004 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1437726AbdDZPFl (ORCPT ); Wed, 26 Apr 2017 11:05:41 -0400 Received: from 1.general.cking.uk.vpn ([10.172.193.212] helo=localhost) by youngberry.canonical.com with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.76) (envelope-from ) id 1d3OVf-000370-K4; Wed, 26 Apr 2017 15:05:39 +0000 From: Colin King To: Marty Plummer , Alexandre Courbot , linux-gpio@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] gpio: f7188x: add missing break in switch statement Date: Wed, 26 Apr 2017 16:05:39 +0100 Message-Id: <20170426150539.11261-1-colin.king@canonical.com> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org From: Colin Ian King The case statement for f71889a is missing a break statement, add it. Detected with CoverityScan, CID#1431861 ("Missig break in switch") Fixes: d69843e416d31 ("gpio: f7188x: Add F71889A GPIO support.") Signed-off-by: Colin Ian King --- drivers/gpio/gpio-f7188x.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpio/gpio-f7188x.c b/drivers/gpio/gpio-f7188x.c index c013ff5deb70..13350c9d7f5e 100644 --- a/drivers/gpio/gpio-f7188x.c +++ b/drivers/gpio/gpio-f7188x.c @@ -398,6 +398,7 @@ static int f7188x_gpio_probe(struct platform_device *pdev) case f71889a: data->nr_bank = ARRAY_SIZE(f71889a_gpio_bank); data->bank = f71889a_gpio_bank; + break; case f71889f: data->nr_bank = ARRAY_SIZE(f71889_gpio_bank); data->bank = f71889_gpio_bank;