| Message ID | 20160613211022.32033-2-paul.gortmaker@windriver.com |
|---|---|
| State | New |
| Headers | show |
On Mon, Jun 13, 2016 at 11:10 PM, Paul Gortmaker <paul.gortmaker@windriver.com> wrote: > The Kconfig currently controlling compilation of this code is: > > config PINCTRL_PALMAS > bool "Pinctrl driver for the PALMAS Series MFD devices" > > ...meaning that it currently is not being built as a module by anyone. > > During an audit for non-modular drivers using modular infrastructure > this driver showed up. > > But rather than demodularize it, Laxman indicated that it would be > prefereable to instead convert the driver option to tristate. > > This does that, and confirms that it will compile and modpost as > such. However, since I do not have the hardware to confirm that > no new runtime issues exist when modular, that remains untested. > > Cc: Laxman Dewangan <ldewangan@nvidia.com> > Cc: Linus Walleij <linus.walleij@linaro.org> > Cc: linux-gpio@vger.kernel.org > Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> Patch applied. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig index ea25eeeceef1..a92e61870024 100644 --- a/drivers/pinctrl/Kconfig +++ b/drivers/pinctrl/Kconfig @@ -218,7 +218,7 @@ config PINCTRL_MAX77620 open drain, FPS slots etc. config PINCTRL_PALMAS - bool "Pinctrl driver for the PALMAS Series MFD devices" + tristate "Pinctrl driver for the PALMAS Series MFD devices" depends on OF && MFD_PALMAS select PINMUX select GENERIC_PINCONF
The Kconfig currently controlling compilation of this code is: config PINCTRL_PALMAS bool "Pinctrl driver for the PALMAS Series MFD devices" ...meaning that it currently is not being built as a module by anyone. During an audit for non-modular drivers using modular infrastructure this driver showed up. But rather than demodularize it, Laxman indicated that it would be prefereable to instead convert the driver option to tristate. This does that, and confirms that it will compile and modpost as such. However, since I do not have the hardware to confirm that no new runtime issues exist when modular, that remains untested. Cc: Laxman Dewangan <ldewangan@nvidia.com> Cc: Linus Walleij <linus.walleij@linaro.org> Cc: linux-gpio@vger.kernel.org Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> --- drivers/pinctrl/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)