From patchwork Tue Feb 16 20:06:58 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dan Carpenter X-Patchwork-Id: 583674 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 33C3D1409C2 for ; Wed, 17 Feb 2016 07:08:05 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753355AbcBPUIE (ORCPT ); Tue, 16 Feb 2016 15:08:04 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:17912 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753266AbcBPUIC (ORCPT ); Tue, 16 Feb 2016 15:08:02 -0500 Received: from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74]) by userp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id u1GK7Gaa018786 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 16 Feb 2016 20:07:16 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by userv0022.oracle.com (8.14.4/8.13.8) with ESMTP id u1GK7CUh000883 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL); Tue, 16 Feb 2016 20:07:14 GMT Received: from abhmp0015.oracle.com (abhmp0015.oracle.com [141.146.116.21]) by userv0121.oracle.com (8.13.8/8.13.8) with ESMTP id u1GK789q009061; Tue, 16 Feb 2016 20:07:08 GMT Received: from mwanda (/154.0.139.178) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 16 Feb 2016 12:07:07 -0800 Date: Tue, 16 Feb 2016 23:06:58 +0300 From: Dan Carpenter To: Linus Walleij , Biao Huang Cc: Matthias Brugger , Hongzhou Yang , Yingjoe Chen , Axel Lin , Javier Martinez Canillas , Maoguang Meng , Jonas Gorski , linux-gpio@vger.kernel.org, linux-mediatek@lists.infradead.org, kernel-janitors@vger.kernel.org Subject: [patch] pinctrl: mediatek: signedness bug in mtk_pmx_gpio_request_enable() Message-ID: <20160216200658.GA9223@mwanda> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.24 (2015-08-30) X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org "muxval" stores a value from 0-255 or a negative error code. It has to be signed for the error handling to work. Fixes: 59ee9c96dd5d ('pinctrl: mediatek: Add gpio_request_enable support') Signed-off-by: Dan Carpenter Reviewed-by: Axel Lin --- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-common.c b/drivers/pinctrl/mediatek/pinctrl-mtk-common.c index cbc2204..1fbaf28 100644 --- a/drivers/pinctrl/mediatek/pinctrl-mtk-common.c +++ b/drivers/pinctrl/mediatek/pinctrl-mtk-common.c @@ -755,14 +755,14 @@ static int mtk_pmx_gpio_request_enable(struct pinctrl_dev *pctldev, struct pinctrl_gpio_range *range, unsigned offset) { - unsigned long muxval; + int muxval; struct mtk_pinctrl *pctl = pinctrl_dev_get_drvdata(pctldev); muxval = mtk_pmx_find_gpio_mode(pctl, offset); if (muxval < 0) { dev_err(pctl->dev, "invalid gpio pin %d.\n", offset); - return -EINVAL; + return muxval; } mtk_pmx_set_mode(pctldev, offset, muxval);