From patchwork Fri Nov 14 21:32:56 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Torokhov X-Patchwork-Id: 411016 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id DDE751400AB for ; Sat, 15 Nov 2014 08:33:01 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161941AbaKNVdA (ORCPT ); Fri, 14 Nov 2014 16:33:00 -0500 Received: from mail-ig0-f177.google.com ([209.85.213.177]:49925 "EHLO mail-ig0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754335AbaKNVdA (ORCPT ); Fri, 14 Nov 2014 16:33:00 -0500 Received: by mail-ig0-f177.google.com with SMTP id uq10so1004016igb.16 for ; Fri, 14 Nov 2014 13:32:59 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-type:content-disposition:user-agent; bh=y7JCqVGSr2vuFs31pvaIaMpl9QzepzYq86K4n73USAQ=; b=hzcQi/Xfbp13NlYXHuBWItHqarCwF89VAAhZzMx469BplAULaSr4r7FJEt2u+8B+zc ahvpKcxLA4FbxpNL4AvmZGd5MxXmehCrI6//l+hHCtR80p8zs/LQXcuhVvRG55oIDw9D JamwArSnjinKGDIgX4NXAn5ek5oh6Oic9VbJ9hCf/NV0EeOTFgRoyfQjidsS1if1+NKl TGK5LVoGHxQoQtVyiYOi1b9zvypYM4lWbI/mOw96HKoC7ezBb7EeoIG2c8D7eDvWKXjy KZaRq7AxPAN+kmqaMhQ0Pqfxbr75lQLvv7C+bOGu/cLJM+uascwbEWdMUQm6Go1RtLfG xOWA== X-Gm-Message-State: ALoCoQkD2SBJ3/zm7U5qx3dw9c5a97xkJfMKtNRHNjjc8SnlyshLcTu3WmZxOguGXpJS3VMsFyWI X-Received: by 10.42.24.10 with SMTP id u10mr13619232icb.58.1416000779361; Fri, 14 Nov 2014 13:32:59 -0800 (PST) Received: from dtor-ws ([2620:0:1000:1301:8c0e:c406:dbcd:b83b]) by mx.google.com with ESMTPSA id w6sm1914789igp.15.2014.11.14.13.32.58 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Fri, 14 Nov 2014 13:32:59 -0800 (PST) Date: Fri, 14 Nov 2014 13:32:56 -0800 From: Dmitry Torokhov To: Linus Walleij Cc: Alexandre Courbot , Wolfram Sang , James Hogan , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] gpio-tz1090: fix error handling of irq_of_parse_and_map Message-ID: <20141114213256.GA24709@dtor-ws> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org irq_of_parse_and_map() returns 0 on error, so testing for negative result never works. Signed-off-by: Dmitry Torokhov Acked-by: James Hogan --- Not tested, found by casual inspection of the code. drivers/gpio/gpio-tz1090.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpio/gpio-tz1090.c b/drivers/gpio/gpio-tz1090.c index 9e90177..e3024bb 100644 --- a/drivers/gpio/gpio-tz1090.c +++ b/drivers/gpio/gpio-tz1090.c @@ -446,7 +446,7 @@ static int tz1090_gpio_bank_probe(struct tz1090_gpio_bank_info *info) bank->irq = irq_of_parse_and_map(np, 0); /* The interrupt is optional (it may be used by another core on chip) */ - if (bank->irq < 0) { + if (!bank->irq) { dev_info(dev, "IRQ not provided for bank %u, IRQs disabled\n", info->index); return 0;