From patchwork Wed Sep 7 14:49:27 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartosz Golaszewski X-Patchwork-Id: 667043 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3sTmfC0LNfz9s36 for ; Thu, 8 Sep 2016 00:52:35 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=baylibre-com.20150623.gappssmtp.com header.i=@baylibre-com.20150623.gappssmtp.com header.b=XcMhOghN; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757636AbcIGOwd (ORCPT ); Wed, 7 Sep 2016 10:52:33 -0400 Received: from mail-wm0-f48.google.com ([74.125.82.48]:35241 "EHLO mail-wm0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754023AbcIGOtm (ORCPT ); Wed, 7 Sep 2016 10:49:42 -0400 Received: by mail-wm0-f48.google.com with SMTP id i204so90461600wma.0 for ; Wed, 07 Sep 2016 07:49:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=mMNZ841sHVIzKe99l5UpzKw4k4VKjQQnB2P0eG0drgE=; b=XcMhOghNF7eqzgJBkK2V3zGhDAxIAWpCgZ6MCWik8XwVhyJeqCY2Vp1PMi9jeSWCT2 N84IjdIGZanZedDaRQxz5sL+fB2EI8DGLNvv75sHDHc0krmMMFJek1QDGtFVFRXrATsR Zuck6NijNuBRQLCwwZxbz/AS50uj+FFERZXdQ50TQLdufiOenLDvnxpkq0m/uZ4/leLH +vS6LkMslTenSUO/09H1XmBykHfhRSxxBxOR4fF7wkeFWySNT1ZeLJvGKEgBA5KLVMCr MmVuITVqoy0S0aud2cAXVKmDy0NKrSjYLPmlsRHvgAGo3T0KZzBEzUf4xlaBuYku2JSW GZfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=mMNZ841sHVIzKe99l5UpzKw4k4VKjQQnB2P0eG0drgE=; b=Gbj+VyHZBBya4mgDu47j9k+CIOLwT8Tw1RH/nbCG9AtjUM3pCVJtsP0OxGQsR/h/MG xen4i3PMmw2B/xSE/YfYuQnB8AWawfa59UoTt0lXaszXoV+nOv8tSwG/MCue82yt1/da cnflEo9Mf1HB24MJAQEf7xcyzjBOwYvLaRWMTG+gZdMudkPIcd+7KMYWZGfEfOR9yA9a LYrVQ/QHURXGiTseira8ZKzf5stZNK/+oB4x4j3unZgx4mvgURMWDqpb8bjV4KXS//4d zKzLyLrr/5CiWB8sMgWibYnfnBUoaumk76M063CKBQYuvqdr5cDqRc7+UBjRH7EnJIC/ 8FjQ== X-Gm-Message-State: AE9vXwPH5M9o7I8DOXw2RiYcvXaWwlplBeOAlgqEKSNYELJibEFOLVN1sUTtRFB7ODGQXfwl X-Received: by 10.194.80.34 with SMTP id o2mr37106716wjx.61.1473259780854; Wed, 07 Sep 2016 07:49:40 -0700 (PDT) Received: from localhost.localdomain ([90.63.244.31]) by smtp.gmail.com with ESMTPSA id s8sm8295544wjz.29.2016.09.07.07.49.39 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 07 Sep 2016 07:49:40 -0700 (PDT) From: Bartosz Golaszewski To: Linus Walleij , Alexandre Courbot , Andy Shevchenko , Vignesh R , Yong Li , Geert Uytterhoeven Cc: linux-gpio , LKML , Bartosz Golaszewski Subject: [PATCH v4 2/5] gpio: pca953x: refactor pca953x_write_regs() Date: Wed, 7 Sep 2016 16:49:27 +0200 Message-Id: <1473259770-26224-3-git-send-email-bgolaszewski@baylibre.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1473259770-26224-1-git-send-email-bgolaszewski@baylibre.com> References: <1473259770-26224-1-git-send-email-bgolaszewski@baylibre.com> Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Avoid the unnecessary if-else in pca953x_write_regs() by splitting the routine into smaller, specialized functions and calling the right one via a function pointer held in struct pca953x_chip. Signed-off-by: Bartosz Golaszewski Reviewed-by: Andy Shevchenko --- drivers/gpio/gpio-pca953x.c | 75 ++++++++++++++++++++++++++++----------------- 1 file changed, 47 insertions(+), 28 deletions(-) diff --git a/drivers/gpio/gpio-pca953x.c b/drivers/gpio/gpio-pca953x.c index d47e6f9..093bec1 100644 --- a/drivers/gpio/gpio-pca953x.c +++ b/drivers/gpio/gpio-pca953x.c @@ -133,6 +133,8 @@ struct pca953x_chip { unsigned long driver_data; const struct pca953x_offset *offset; + + int (*write_regs)(struct pca953x_chip *, int, u8 *); }; static int pca953x_read_single(struct pca953x_chip *chip, int reg, u32 *val, @@ -172,38 +174,44 @@ static int pca953x_write_single(struct pca953x_chip *chip, int reg, u32 val, return 0; } -static int pca953x_write_regs(struct pca953x_chip *chip, int reg, u8 *val) +static int pca953x_write_regs_8(struct pca953x_chip *chip, int reg, u8 *val) { - int ret = 0; + return i2c_smbus_write_byte_data(chip->client, reg, *val); +} - if (chip->gpio_chip.ngpio <= 8) - ret = i2c_smbus_write_byte_data(chip->client, reg, *val); - else if (chip->gpio_chip.ngpio >= 24) { - int bank_shift = fls((chip->gpio_chip.ngpio - 1) / BANK_SZ); - ret = i2c_smbus_write_i2c_block_data(chip->client, - (reg << bank_shift) | REG_ADDR_AI, - NBANK(chip), val); - } else { - switch (chip->chip_type) { - case PCA953X_TYPE: { - __le16 word = cpu_to_le16(get_unaligned((u16 *)val)); +static int pca953x_write_regs_16(struct pca953x_chip *chip, int reg, u8 *val) +{ + __le16 word = cpu_to_le16(get_unaligned((u16 *)val)); - ret = i2c_smbus_write_word_data(chip->client, reg << 1, - (__force u16)word); - break; - } - case PCA957X_TYPE: - ret = i2c_smbus_write_byte_data(chip->client, reg << 1, - val[0]); - if (ret < 0) - break; - ret = i2c_smbus_write_byte_data(chip->client, - (reg << 1) + 1, - val[1]); - break; - } - } + return i2c_smbus_write_word_data(chip->client, + reg << 1, (__force u16)word); +} + +static int pca957x_write_regs_16(struct pca953x_chip *chip, int reg, u8 *val) +{ + int ret; + + ret = i2c_smbus_write_byte_data(chip->client, reg << 1, val[0]); + if (ret < 0) + return ret; + + return i2c_smbus_write_byte_data(chip->client, (reg << 1) + 1, val[1]); +} +static int pca953x_write_regs_24(struct pca953x_chip *chip, int reg, u8 *val) +{ + int bank_shift = fls((chip->gpio_chip.ngpio - 1) / BANK_SZ); + + return i2c_smbus_write_i2c_block_data(chip->client, + (reg << bank_shift) | REG_ADDR_AI, + NBANK(chip), val); +} + +static int pca953x_write_regs(struct pca953x_chip *chip, int reg, u8 *val) +{ + int ret = 0; + + ret = chip->write_regs(chip, reg, val); if (ret < 0) { dev_err(&chip->client->dev, "failed writing register\n"); return ret; @@ -754,6 +762,17 @@ static int pca953x_probe(struct i2c_client *client, */ pca953x_setup_gpio(chip, chip->driver_data & PCA_GPIO_MASK); + if (chip->gpio_chip.ngpio <= 8) { + chip->write_regs = pca953x_write_regs_8; + } else if (chip->gpio_chip.ngpio >= 24) { + chip->write_regs = pca953x_write_regs_24; + } else { + if (PCA_CHIP_TYPE(chip->driver_data) == PCA953X_TYPE) + chip->write_regs = pca953x_write_regs_16; + else + chip->write_regs = pca957x_write_regs_16; + } + if (chip->chip_type == PCA953X_TYPE) ret = device_pca953x_init(chip, invert); else