From patchwork Tue May 31 13:04:35 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laxman Dewangan X-Patchwork-Id: 628233 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3rJvCx4bKXz9t5Q for ; Tue, 31 May 2016 23:17:17 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753876AbcEaNRR (ORCPT ); Tue, 31 May 2016 09:17:17 -0400 Received: from hqemgate16.nvidia.com ([216.228.121.65]:3765 "EHLO hqemgate16.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753290AbcEaNRQ (ORCPT ); Tue, 31 May 2016 09:17:16 -0400 Received: from hqnvupgp08.nvidia.com (Not Verified[216.228.121.13]) by hqemgate16.nvidia.com id ; Tue, 31 May 2016 06:17:12 -0700 Received: from HQMAIL101.nvidia.com ([172.20.187.10]) by hqnvupgp08.nvidia.com (PGP Universal service); Tue, 31 May 2016 06:15:21 -0700 X-PGP-Universal: processed; by hqnvupgp08.nvidia.com on Tue, 31 May 2016 06:15:21 -0700 Received: from BGMAIL104.nvidia.com (10.25.59.13) by HQMAIL101.nvidia.com (172.20.187.10) with Microsoft SMTP Server (TLS) id 15.0.1130.7; Tue, 31 May 2016 13:17:14 +0000 Received: from HQMAIL104.nvidia.com (172.18.146.11) by bgmail104.nvidia.com (10.25.59.13) with Microsoft SMTP Server (TLS) id 15.0.1130.7; Tue, 31 May 2016 13:17:11 +0000 Received: from ldewanganubuntu-System-Product-Name.nvidia.com (172.20.13.39) by HQMAIL104.nvidia.com (172.18.146.11) with Microsoft SMTP Server id 15.0.1130.7 via Frontend Transport; Tue, 31 May 2016 13:17:08 +0000 From: Laxman Dewangan To: CC: , , , Laxman Dewangan Subject: [PATCH V2] gpio: max77620: Implement gpio_get_direction callback Date: Tue, 31 May 2016 18:34:35 +0530 Message-ID: <1464699875-6641-1-git-send-email-ldewangan@nvidia.com> X-Mailer: git-send-email 2.1.4 MIME-Version: 1.0 Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Implement gpio_get_direction() callback for MAX77620 GPIO. This is useful for debugfs and the userspace ABI. Signed-off-by: Laxman Dewangan --- Changes from V1: Earlier it was part of series to implement get_directiona dn set_single_mode. Other patches are alreadya pplied and hence making this as single patch. On this patch: - remove the inclusion of gpio.h - Do not use GPIOF flags. drivers/gpio/gpio-max77620.c | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/drivers/gpio/gpio-max77620.c b/drivers/gpio/gpio-max77620.c index 8658c32..3f34b52 100644 --- a/drivers/gpio/gpio-max77620.c +++ b/drivers/gpio/gpio-max77620.c @@ -152,6 +152,22 @@ static int max77620_gpio_dir_output(struct gpio_chip *gc, unsigned int offset, return ret; } +static int max77620_gpio_get_direction(struct gpio_chip *gc, + unsigned int offset) +{ + struct max77620_gpio *mgpio = gpiochip_get_data(gc); + unsigned int val; + int ret; + + ret = regmap_read(mgpio->rmap, GPIO_REG_ADDR(offset), &val); + if (ret < 0) { + dev_err(mgpio->dev, "GPIO register read failed: %d\n", ret); + return ret; + } + + return !!(val & MAX77620_CNFG_GPIO_DIR_MASK); +} + static int max77620_gpio_set_debounce(struct gpio_chip *gc, unsigned int offset, unsigned int debounce) @@ -258,6 +274,7 @@ static int max77620_gpio_probe(struct platform_device *pdev) mgpio->gpio_chip.direction_input = max77620_gpio_dir_input; mgpio->gpio_chip.get = max77620_gpio_get; mgpio->gpio_chip.direction_output = max77620_gpio_dir_output; + mgpio->gpio_chip.get_direction = max77620_gpio_get_direction; mgpio->gpio_chip.set_debounce = max77620_gpio_set_debounce; mgpio->gpio_chip.set = max77620_gpio_set; mgpio->gpio_chip.set_single_ended = max77620_gpio_set_single_ended;