From patchwork Tue Jul 21 06:25:27 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 498011 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 6029A140DF7 for ; Tue, 21 Jul 2015 16:25:59 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752191AbbGUGZ6 (ORCPT ); Tue, 21 Jul 2015 02:25:58 -0400 Received: from conuserg011.nifty.com ([202.248.44.37]:50034 "EHLO conuserg011-v.nifty.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751802AbbGUGZ5 (ORCPT ); Tue, 21 Jul 2015 02:25:57 -0400 Received: from beagle.diag.org (KD014014081130.au-net.ne.jp [14.14.81.130]) (authenticated) by conuserg011-v.nifty.com with ESMTP id t6L6PXqD012270; Tue, 21 Jul 2015 15:25:38 +0900 X-Nifty-SrcIP: [14.14.81.130] From: Masahiro Yamada To: linux-gpio@vger.kernel.org Cc: Masahiro Yamada , Linus Walleij , linux-kernel@vger.kernel.org Subject: [PATCH 2/2] pinctrl: use dev_err() to show message in pinmux_func_name_to_selector() Date: Tue, 21 Jul 2015 15:25:27 +0900 Message-Id: <1437459927-5278-2-git-send-email-yamada.masahiro@socionext.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1437459927-5278-1-git-send-email-yamada.masahiro@socionext.com> References: <1437459927-5278-1-git-send-email-yamada.masahiro@socionext.com> Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Use dev_err() rather than pr_err() to display the error message. pinctrl_dev_get_name(pctldev) is no longer necessary because dev_err() shows which device the message is related to. Signed-off-by: Masahiro Yamada --- drivers/pinctrl/pinmux.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/pinctrl/pinmux.c b/drivers/pinctrl/pinmux.c index 766ec57..18ce18c 100644 --- a/drivers/pinctrl/pinmux.c +++ b/drivers/pinctrl/pinmux.c @@ -322,8 +322,7 @@ static int pinmux_func_name_to_selector(struct pinctrl_dev *pctldev, selector++; } - pr_err("%s does not support function %s\n", - pinctrl_dev_get_name(pctldev), function); + dev_err(pctldev->dev, "function '%s' not supported\n", function); return -EINVAL; }