From patchwork Tue Jul 14 22:25:26 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joachim Eastwood X-Patchwork-Id: 495280 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id D008014077C for ; Wed, 15 Jul 2015 08:25:44 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b=yYyz56PF; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752183AbbGNWZn (ORCPT ); Tue, 14 Jul 2015 18:25:43 -0400 Received: from mail-lb0-f193.google.com ([209.85.217.193]:33739 "EHLO mail-lb0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751746AbbGNWZn (ORCPT ); Tue, 14 Jul 2015 18:25:43 -0400 Received: by lbbnr7 with SMTP id nr7so1043647lbb.0 for ; Tue, 14 Jul 2015 15:25:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=U9jJdF2qtBmfQBsSkI7iHREoo3NMZl5CJkcWQQkc3Lg=; b=yYyz56PF4AFNKZDlT2apAqIZewAGVgGm2z3ri6cfO7EHaXHnxPlAHLF5H8KhkH9erb Q9WJSZ+bisvqrSWczLSTWINwErTDiGxCtDNhH3WtJFqKbhnFvMbbramyVxHv6dDxENJA pi4djMfG/5ybYBgzaGXiHxGijMsFXQjO/ZSiTDHV5t7oP2T14cgHjZ//bhYK4K/jiC7f IwF+11bLmR8yzUYgfWcX7x0lqZbMsOnRxndRIElEGVIzIYrwre0PMOJDaw42Bh5SgjC+ LIvvi6D7j4M/mUgN4W85baYE2d+o2Hcu3zaB/jfDHKKCX9tXieKMhEvh9N+0dokUGeKD UmSw== X-Received: by 10.152.184.44 with SMTP id er12mr862346lac.94.1436912741638; Tue, 14 Jul 2015 15:25:41 -0700 (PDT) Received: from localhost.localdomain ([89.11.213.141]) by smtp.gmail.com with ESMTPSA id ks11sm589017lac.0.2015.07.14.15.25.40 (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 14 Jul 2015 15:25:41 -0700 (PDT) From: Joachim Eastwood To: linus.walleij@linaro.org Cc: Joachim Eastwood , linux-gpio@vger.kernel.org Subject: [PATCH 1/2] pinctrl: lpc18xx: fix schmitt trigger setup Date: Wed, 15 Jul 2015 00:25:26 +0200 Message-Id: <1436912727-11559-2-git-send-email-manabian@gmail.com> X-Mailer: git-send-email 1.8.0 In-Reply-To: <1436912727-11559-1-git-send-email-manabian@gmail.com> References: <1436912727-11559-1-git-send-email-manabian@gmail.com> Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org The param_val variable is what determines if schmitt trigger is enabled on a pin or not. A typo here mean that schmitt trigger was always enabled for standard and i2c pins. Signed-off-by: Joachim Eastwood --- drivers/pinctrl/pinctrl-lpc18xx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/pinctrl/pinctrl-lpc18xx.c b/drivers/pinctrl/pinctrl-lpc18xx.c index ef0b697639a7..347c763a6a78 100644 --- a/drivers/pinctrl/pinctrl-lpc18xx.c +++ b/drivers/pinctrl/pinctrl-lpc18xx.c @@ -823,7 +823,7 @@ static int lpc18xx_pconf_set_i2c0(struct pinctrl_dev *pctldev, break; case PIN_CONFIG_INPUT_SCHMITT_ENABLE: - if (param) + if (param_val) *reg &= ~(LPC18XX_SCU_I2C0_ZIF << shift); else *reg |= (LPC18XX_SCU_I2C0_ZIF << shift); @@ -876,7 +876,7 @@ static int lpc18xx_pconf_set_pin(struct pinctrl_dev *pctldev, break; case PIN_CONFIG_INPUT_SCHMITT_ENABLE: - if (param) + if (param_val) *reg &= ~LPC18XX_SCU_PIN_ZIF; else *reg |= LPC18XX_SCU_PIN_ZIF;