From patchwork Thu Jul 9 13:19:53 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 493412 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3FAC31402A2 for ; Thu, 9 Jul 2015 23:20:29 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b=gvjTi3GD; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753269AbbGINUY (ORCPT ); Thu, 9 Jul 2015 09:20:24 -0400 Received: from mail-pa0-f51.google.com ([209.85.220.51]:34645 "EHLO mail-pa0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754143AbbGINUM (ORCPT ); Thu, 9 Jul 2015 09:20:12 -0400 Received: by pabvl15 with SMTP id vl15so150470954pab.1; Thu, 09 Jul 2015 06:20:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=OtPZhGhemd76Kj02HOMc+SlBZSMpL/y3c5MNJ28EwXM=; b=gvjTi3GDf4ClU3K++kqQGDV+1DHDU1dEfda5N0+PbSuJ1Zvo74DVDiBECwVluanvPH +6RGUK+c+yz4JZkq1qhXKFqJ8k/6WmtFFqqJLaCR/TZDXpqI+emieFK/0u6u5A5M2Fcl iLlNrYl7Y3CPfFXrhe9qMnbMiTpgx2W8LmTXUWqFPOcF7X44DBampsPCGTr5/c2W/JZp 65IUsxCwgNHzSpHWlR2ziZWC+TVnYV7fWb++Ckw/igv0OpRH5rHK6CO3PNA/39qiICMe SaHrVu0BiGIUQz6McWwNKOLWGuHyjwQcQ72VLqxnnvJ3CG5oawpzdvvLGoMUh1ZjCFAi QSpA== X-Received: by 10.70.24.33 with SMTP id r1mr31733531pdf.74.1436448011123; Thu, 09 Jul 2015 06:20:11 -0700 (PDT) Received: from localhost.localdomain ([125.130.175.98]) by smtp.gmail.com with ESMTPSA id d5sm6012148pdl.85.2015.07.09.06.20.08 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 09 Jul 2015 06:20:10 -0700 (PDT) From: Krzysztof Kozlowski To: Linus Walleij , Alexandre Courbot , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski , Subject: [RFT PATCH] gpio: etraxfs: Fix devm_ioremap_resource return value check Date: Thu, 9 Jul 2015 22:19:53 +0900 Message-Id: <1436447993-24630-1-git-send-email-k.kozlowski.k@gmail.com> X-Mailer: git-send-email 2.1.4 Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Value returned by devm_ioremap_resource() was checked for non-NULL but devm_ioremap_resource() returns IOMEM_ERR_PTR, not NULL. In case of error this could lead to dereference of ERR_PTR. Signed-off-by: Krzysztof Kozlowski Fixes: d342571efea8 ("gpio: add ETRAXFS GPIO driver") Cc: Acked-by: Alexandre Courbot Acked-by: Rabin Vincent --- Patch only compile tested. --- drivers/gpio/gpio-etraxfs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpio/gpio-etraxfs.c b/drivers/gpio/gpio-etraxfs.c index 28071f4a5672..0e643140efde 100644 --- a/drivers/gpio/gpio-etraxfs.c +++ b/drivers/gpio/gpio-etraxfs.c @@ -117,8 +117,8 @@ static int etraxfs_gpio_probe(struct platform_device *pdev) res = platform_get_resource(pdev, IORESOURCE_MEM, 0); regs = devm_ioremap_resource(dev, res); - if (!regs) - return -ENOMEM; + if (IS_ERR(regs)) + return PTR_ERR(regs); match = of_match_node(etraxfs_gpio_of_table, dev->of_node); if (!match)