Message ID | 1430752248-15401-18-git-send-email-johan@kernel.org |
---|---|
State | New |
Headers | show |
On Mon, May 4, 2015 at 5:10 PM, Johan Hovold <johan@kernel.org> wrote: > Remove goto from success path. > > Signed-off-by: Johan Hovold <johan@kernel.org> Patch applied. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/gpio/gpiolib-sysfs.c b/drivers/gpio/gpiolib-sysfs.c index d9b3faa01fee..1161a46618dd 100644 --- a/drivers/gpio/gpiolib-sysfs.c +++ b/drivers/gpio/gpiolib-sysfs.c @@ -236,14 +236,16 @@ static ssize_t edge_store(struct device *dev, struct gpio_desc *desc = data->desc; unsigned long flags; ssize_t status = size; - int i; + int i; - for (i = 0; i < ARRAY_SIZE(trigger_types); i++) + for (i = 0; i < ARRAY_SIZE(trigger_types); i++) { if (sysfs_streq(trigger_types[i].name, buf)) - goto found; - return -EINVAL; + break; + } + + if (i == ARRAY_SIZE(trigger_types)) + return -EINVAL; -found: flags = trigger_types[i].flags; mutex_lock(&sysfs_lock);
Remove goto from success path. Signed-off-by: Johan Hovold <johan@kernel.org> --- drivers/gpio/gpiolib-sysfs.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-)