From patchwork Sat Mar 14 07:15:18 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Axel Lin X-Patchwork-Id: 450167 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id DB35C1400D5 for ; Sat, 14 Mar 2015 18:15:25 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752759AbbCNHPY (ORCPT ); Sat, 14 Mar 2015 03:15:24 -0400 Received: from mail-pd0-f170.google.com ([209.85.192.170]:34232 "EHLO mail-pd0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752481AbbCNHPX (ORCPT ); Sat, 14 Mar 2015 03:15:23 -0400 Received: by pdbni2 with SMTP id ni2so6827561pdb.1 for ; Sat, 14 Mar 2015 00:15:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:subject:from:to:cc:date:content-type :mime-version:content-transfer-encoding; bh=6QYCuS5IAKq7I9hikrFdvypfB3/rY5VZ0Wc62z0AK5U=; b=Jk6UdIrSALZ7pNt4DN+wEv8VHQVOP8oqQpF/2x5tQ93XZnqtbR6cTkVnRhkU3ayEYP 2opkgCKkVteO82K5m+QzpRkjCY92BMOgPg3MFxHxjGB8xXaP265X8+Erq5ovZ9+qVq7J k3EyanVLHxL3Gkzc5hAWYFeTvIrDcifsPTu7SJ1j/5Wuskqr89LCjOoVlb25Kj1oz/VL ORbwWtkBYJR62wgKEDTfGyQVkp7SWWNkthrBIOcHdTICghKzpFCRgNMjxwcjjvDNH03O NDqnHdvisBbYOmPS6TuKo1Gg3/3XdxNc/WfYU6QAO9AD79gqL3X14ECJAGlj8zigCDOw M5DQ== X-Gm-Message-State: ALoCoQnj56y3LNtJ6ruk/6CzP0U7nI21U7I/sLnU6KZ2IOe48PExDHL5ueC6hAL/5d2UUCyHQe84 X-Received: by 10.70.38.227 with SMTP id j3mr78940086pdk.149.1426317322971; Sat, 14 Mar 2015 00:15:22 -0700 (PDT) Received: from [192.168.0.104] (218-164-131-20.dynamic.hinet.net. [218.164.131.20]) by mx.google.com with ESMTPSA id nw3sm6682114pdb.71.2015.03.14.00.15.20 (version=TLSv1.2 cipher=AES128-GCM-SHA256 bits=128/128); Sat, 14 Mar 2015 00:15:21 -0700 (PDT) Message-ID: <1426317318.15425.1.camel@phoenix> Subject: [PATCH RFT] pinctrl: mediatek: mtk-common: Fix a typo in mtk_eint_set_type From: Axel Lin To: Linus Walleij Cc: Matthias Brugger , Hongzhou Yang , "linux-gpio@vger.kernel.org" Date: Sat, 14 Mar 2015 15:15:18 +0800 X-Mailer: Evolution 3.10.4-0ubuntu2 Mime-Version: 1.0 Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Fix a typo when checking level trigger irq type. Signed-off-by: Axel Lin --- Hi Hongzhou, This looks like a typo, but I don't have the datasheet so please confirm if this patch is correct or not. drivers/pinctrl/mediatek/pinctrl-mtk-common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-common.c b/drivers/pinctrl/mediatek/pinctrl-mtk-common.c index 493294c..cc27929 100644 --- a/drivers/pinctrl/mediatek/pinctrl-mtk-common.c +++ b/drivers/pinctrl/mediatek/pinctrl-mtk-common.c @@ -934,7 +934,7 @@ static int mtk_eint_set_type(struct irq_data *d, else pctl->eint_dual_edges[d->hwirq] = 0; - if (type & (IRQ_TYPE_LEVEL_LOW | IRQ_TYPE_EDGE_FALLING)) { + if (type & (IRQ_TYPE_LEVEL_LOW | IRQ_TYPE_LEVEL_HIGH)) { reg = mtk_eint_get_offset(pctl, d->hwirq, eint_offsets->pol_clr); writel(mask, reg);