From patchwork Fri Mar 6 19:26:56 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: grygorii.strashko@linaro.org X-Patchwork-Id: 447415 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 6B446140146 for ; Sat, 7 Mar 2015 06:27:11 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755476AbbCFT1K (ORCPT ); Fri, 6 Mar 2015 14:27:10 -0500 Received: from mail-lb0-f170.google.com ([209.85.217.170]:32856 "EHLO mail-lb0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755684AbbCFT1I (ORCPT ); Fri, 6 Mar 2015 14:27:08 -0500 Received: by lbdu14 with SMTP id u14so38559478lbd.0 for ; Fri, 06 Mar 2015 11:27:06 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=BUV/3Y95MkRtQ+lKYBRrxdbLzOMnlZxNQ8O3m9FnhzM=; b=Qrx/BBFWGA6MswJ4psLnOlExiYW8SxzF98dzlCItknTeOH92txu4dXiQ5Ff2vBpAbj Aacv5gVZQdUCYiVi+TN6zzaHsdbxzrFerFei3dEYBc6FSg55otkAen0USCU5D2NIpX26 nucY82tNuacphzwKHPtfpG69J65bm8ELj9gmoP2i4FzwkYwkhZqozr26dtB0rA2lodoS 6K76KuO48Il60/bUaW5b4/w9UndG9nYkC8vyA1LEwqeuX+WOLda7UPy80zqR1xj9aHj5 He57zgzMdFPv7ne56xS6NvUelVQJDGoRhyw3v52ucp4D/2FYgcSF0/0R5DZihBJzrTXQ faLA== X-Gm-Message-State: ALoCoQlFqiq5Z+Hsvs6BVpIxkmRASMi5B7b7GqUdEX0yayqYMXzpDNfqti6uB/xSlAGdzSmIQEeG X-Received: by 10.152.204.42 with SMTP id kv10mr8083942lac.52.1425670026519; Fri, 06 Mar 2015 11:27:06 -0800 (PST) Received: from localhost ([195.238.92.128]) by mx.google.com with ESMTPSA id i6sm1967973lai.1.2015.03.06.11.27.05 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Fri, 06 Mar 2015 11:27:06 -0800 (PST) From: To: Linus Walleij , ssantosh@kernel.org, Javier Martinez Canillas , tony@atomide.com Cc: Alexandre Courbot , linux-omap@vger.kernel.org, linux-gpio@vger.kernel.org, Grygorii Strashko Subject: [PATCH 1/2] gpio: omap: irq_shutdown: remove unnecessary call of gpiochip_unlock_as_irq Date: Fri, 6 Mar 2015 21:26:56 +0200 Message-Id: <1425670017-19598-1-git-send-email-grygorii.strashko@linaro.org> X-Mailer: git-send-email 1.9.1 Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org From: Grygorii Strashko GPIOLib core implemnts irqchip->irq_request/release_resources callbacks internally and these callbacks already contain clalls of gpiochip_lock/unlock_as_irq(). Hence, remove unnecessary call of gpiochip_unlock_as_irq() from omap_gpio_irq_shutdown(). Signed-off-by: Grygorii Strashko --- drivers/gpio/gpio-omap.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpio/gpio-omap.c b/drivers/gpio/gpio-omap.c index f476ae2..2b2fc4b 100644 --- a/drivers/gpio/gpio-omap.c +++ b/drivers/gpio/gpio-omap.c @@ -826,7 +826,6 @@ static void omap_gpio_irq_shutdown(struct irq_data *d) unsigned offset = GPIO_INDEX(bank, gpio); spin_lock_irqsave(&bank->lock, flags); - gpiochip_unlock_as_irq(&bank->chip, offset); bank->irq_usage &= ~(BIT(offset)); omap_disable_gpio_module(bank, offset); omap_reset_gpio(bank, gpio);