From patchwork Sun Jan 18 11:39:30 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ricardo Ribalda Delgado X-Patchwork-Id: 430178 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 0D6D41401AC for ; Sun, 18 Jan 2015 22:41:49 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751924AbbARLlf (ORCPT ); Sun, 18 Jan 2015 06:41:35 -0500 Received: from mail-lb0-f169.google.com ([209.85.217.169]:45014 "EHLO mail-lb0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752350AbbARLj4 (ORCPT ); Sun, 18 Jan 2015 06:39:56 -0500 Received: by mail-lb0-f169.google.com with SMTP id f15so3716645lbj.0; Sun, 18 Jan 2015 03:39:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=bG5t6dd9UVPJvhIFAtDn5GS8VXValWwBCNpLQ6yDL7I=; b=HBOrw2XVqvVs0gsgGZGQbCejYXIc4X9HrGwhZA1hU7htO3sSGqOwlIOkFED8JoNR7t +ExyQ3hXEEgUoUbeA1ih5fBebXaaSLOwcQeNhiDGUr5pZXBXFvWj2rQCb9jzr85h60BB 4sdVCtx98TD+c2KkwJOZPtkoFkYSf5cMzwP6N134Soq+hY4HnLZ1LDQnOkZ/sc4ohzx7 yrfZGUmSbA156ghSRA6EnpVNmv2+mtugUx8cSqgjBzEy22HIXLeiI2Rt5dLKIMoaHLI7 A5p30aJxoC3E2KUBobE6wDWH3uLpz2V1/99R8OulOPj2FVxXnaoqDL38t90Dh7QHDjOh Sgdw== X-Received: by 10.152.45.4 with SMTP id i4mr24724399lam.74.1421581195127; Sun, 18 Jan 2015 03:39:55 -0800 (PST) Received: from localhost.localdomain (x1-6-30-46-9a-6d-3c-54.cpe.webspeed.dk. [2.108.161.190]) by mx.google.com with ESMTPSA id s16sm2829856lal.5.2015.01.18.03.39.54 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sun, 18 Jan 2015 03:39:54 -0800 (PST) From: Ricardo Ribalda Delgado To: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Ricardo Ribalda Delgado , Linus Walleij , Alexandre Courbot , John Crispin Subject: [PATCH 5/8] gpio/gpio-mm-lantiq: Use of_mm_gpiochip_remove Date: Sun, 18 Jan 2015 12:39:30 +0100 Message-Id: <1421581173-28416-6-git-send-email-ricardo.ribalda@gmail.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1421581173-28416-1-git-send-email-ricardo.ribalda@gmail.com> References: <1421581173-28416-1-git-send-email-ricardo.ribalda@gmail.com> Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Since d621e8bae5ac9c67 (Create of_mm_gpiochip_remove), there is a counterpart for of_mm_gpiochip_add. This patch implements the remove function of the driver making use of it. Cc: Linus Walleij Cc: Alexandre Courbot Cc: John Crispin Signed-off-by: Ricardo Ribalda Delgado --- drivers/gpio/gpio-mm-lantiq.c | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/drivers/gpio/gpio-mm-lantiq.c b/drivers/gpio/gpio-mm-lantiq.c index b511a6b..082c1d5 100644 --- a/drivers/gpio/gpio-mm-lantiq.c +++ b/drivers/gpio/gpio-mm-lantiq.c @@ -110,6 +110,8 @@ static int ltq_mm_probe(struct platform_device *pdev) if (!chip) return -ENOMEM; + platform_set_drvdata(pdev, chip); + chip->mmchip.gc.ngpio = 16; chip->mmchip.gc.direction_output = ltq_mm_dir_out; chip->mmchip.gc.set = ltq_mm_set; @@ -122,6 +124,15 @@ static int ltq_mm_probe(struct platform_device *pdev) return of_mm_gpiochip_add(pdev->dev.of_node, &chip->mmchip); } +static int ltq_mm_remove(struct platform_device *pdev) +{ + struct ltq_mm *chip = platform_get_drvdata(pdev); + + of_mm_gpiochip_remove(&chip->mmchip); + + return 0; +} + static const struct of_device_id ltq_mm_match[] = { { .compatible = "lantiq,gpio-mm" }, {}, @@ -130,6 +141,7 @@ MODULE_DEVICE_TABLE(of, ltq_mm_match); static struct platform_driver ltq_mm_driver = { .probe = ltq_mm_probe, + .remove = ltq_mm_remove, .driver = { .name = "gpio-mm-ltq", .of_match_table = ltq_mm_match, @@ -142,3 +154,9 @@ static int __init ltq_mm_init(void) } subsys_initcall(ltq_mm_init); + +static void __exit ltq_mm_exit(void) +{ + platform_driver_unregister(<q_mm_driver); +} +module_exit(ltq_mm_exit);