From patchwork Sun Jan 18 11:39:29 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ricardo Ribalda Delgado X-Patchwork-Id: 430176 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 41B751401AC for ; Sun, 18 Jan 2015 22:41:32 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752505AbbARLj6 (ORCPT ); Sun, 18 Jan 2015 06:39:58 -0500 Received: from mail-la0-f50.google.com ([209.85.215.50]:34073 "EHLO mail-la0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752317AbbARLj4 (ORCPT ); Sun, 18 Jan 2015 06:39:56 -0500 Received: by mail-la0-f50.google.com with SMTP id pn19so24789956lab.9; Sun, 18 Jan 2015 03:39:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=n8lEkJzyyhidFLK6q3oJTn6nKdzzJ6Q+hiaB0K8PYzk=; b=cvRlw6VU70Tx70Rnit3iJhSm+z9Kux3lPgrHwDq5dLhwm4lrjQbD2LHWdArsxeLc37 +Wm93hMpOQhs+yFc9lEJspLUAdj4Cqtevpok1aNsdcMY9vjf1sD89pEygs+ZWP9SvVso El/M5H5VJ5BKJoOmY47ltwMXEez1CmGAjuh9Mk+UsGe6hYa++mCK4VfPJDH/n4A5w3cC eFSN58UX5+RTHzMKvcoQziYQRNigGXNOeT+BrQrSQTjhuVL+6RRvqwK44nBSSKEOFuGk rZimdJKHP21B7xMtiU8MVepjIInF3I6IOJBoBRhz7EN87unKXVFCaI05JOKMB5AKe/Fu N8Jg== X-Received: by 10.153.4.2 with SMTP id ca2mr24516179lad.40.1421581194213; Sun, 18 Jan 2015 03:39:54 -0800 (PST) Received: from localhost.localdomain (x1-6-30-46-9a-6d-3c-54.cpe.webspeed.dk. [2.108.161.190]) by mx.google.com with ESMTPSA id s16sm2829856lal.5.2015.01.18.03.39.53 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sun, 18 Jan 2015 03:39:53 -0800 (PST) From: Ricardo Ribalda Delgado To: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Ricardo Ribalda Delgado , Linus Walleij , Alexandre Courbot , Grant Likely , Rob Herring , John Crispin , devicetree@vger.kernel.org Subject: [PATCH 4/8] gpio-mm-lantiq: Use of_propery_read_u16 Date: Sun, 18 Jan 2015 12:39:29 +0100 Message-Id: <1421581173-28416-5-git-send-email-ricardo.ribalda@gmail.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1421581173-28416-1-git-send-email-ricardo.ribalda@gmail.com> References: <1421581173-28416-1-git-send-email-ricardo.ribalda@gmail.com> Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Instead of parsing manually the shadow content, use the much simpler helper of_property_read_u16. Cc: Linus Walleij Cc: Alexandre Courbot Cc: Grant Likely Cc: Rob Herring Cc: John Crispin Cc: devicetree@vger.kernel.org Signed-off-by: Ricardo Ribalda Delgado --- drivers/gpio/gpio-mm-lantiq.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpio/gpio-mm-lantiq.c b/drivers/gpio/gpio-mm-lantiq.c index 7d55161..b511a6b 100644 --- a/drivers/gpio/gpio-mm-lantiq.c +++ b/drivers/gpio/gpio-mm-lantiq.c @@ -105,7 +105,6 @@ static void ltq_mm_save_regs(struct of_mm_gpio_chip *mm_gc) static int ltq_mm_probe(struct platform_device *pdev) { struct ltq_mm *chip; - const __be32 *shadow; chip = devm_kzalloc(&pdev->dev, sizeof(*chip), GFP_KERNEL); if (!chip) @@ -117,9 +116,8 @@ static int ltq_mm_probe(struct platform_device *pdev) chip->mmchip.save_regs = ltq_mm_save_regs; /* store the shadow value if one was passed by the devicetree */ - shadow = of_get_property(pdev->dev.of_node, "lantiq,shadow", NULL); - if (shadow) - chip->shadow = be32_to_cpu(*shadow); + of_property_read_u16(pdev->dev.of_node, "lantiq,shadow", + &chip->shadow); return of_mm_gpiochip_add(pdev->dev.of_node, &chip->mmchip); }