| Message ID | 1415693323-19046-1-git-send-email-alexander.stein@systec-electronic.com |
|---|---|
| State | Accepted |
| Headers | show |
On Tue, Nov 11, 2014 at 9:08 AM, Alexander Stein <alexander.stein@systec-electronic.com> wrote: > If devm_request_threaded_irq fails for some reason we call > mcp23s08_irq_teardown afterwards. > Do not free the unrequested interrupt in this case. free_irq can also be > omitted for the error free case because we use devm_request_threaded_irq. > > Signed-off-by: Alexander Stein <alexander.stein@systec-electronic.com> Patch applied. We don't have a maintainer for this driver... I'd like someone to look into converting it to use GPIOLIB_IRQCHIP. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/gpio/gpio-mcp23s08.c b/drivers/gpio/gpio-mcp23s08.c index 8488e2f..d5e9586 100644 --- a/drivers/gpio/gpio-mcp23s08.c +++ b/drivers/gpio/gpio-mcp23s08.c @@ -514,8 +514,6 @@ static void mcp23s08_irq_teardown(struct mcp23s08 *mcp) { unsigned int irq, i; - free_irq(mcp->irq, mcp); - for (i = 0; i < mcp->chip.ngpio; i++) { irq = irq_find_mapping(mcp->irq_domain, i); if (irq > 0)
If devm_request_threaded_irq fails for some reason we call mcp23s08_irq_teardown afterwards. Do not free the unrequested interrupt in this case. free_irq can also be omitted for the error free case because we use devm_request_threaded_irq. Signed-off-by: Alexander Stein <alexander.stein@systec-electronic.com> --- drivers/gpio/gpio-mcp23s08.c | 2 -- 1 file changed, 2 deletions(-)