From patchwork Wed Mar 27 04:57:55 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: William Breathitt Gray X-Patchwork-Id: 1066476 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-gpio-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="jhmR+IB4"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 44TbMx35qvz9sSR for ; Wed, 27 Mar 2019 15:57:33 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725829AbfC0E5c (ORCPT ); Wed, 27 Mar 2019 00:57:32 -0400 Received: from mail-pg1-f193.google.com ([209.85.215.193]:41842 "EHLO mail-pg1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725763AbfC0E5c (ORCPT ); Wed, 27 Mar 2019 00:57:32 -0400 Received: by mail-pg1-f193.google.com with SMTP id f6so5220096pgs.8; Tue, 26 Mar 2019 21:57:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=aDg494jtgErGqiuDA2DRjeEz9+0QgIkJR2NqCdRXVXs=; b=jhmR+IB4bJEDLObmykQh0VEJGwfRIVC3QWWLrTFYqZSk4BA+9XE2FeeeFBYR2ws0sL bz8BLa7NFKibWHi3CV72P3YeKhBnQ8gx8USwQ+njX8rPk7CpFta8B8ymRRNBwhQ4zL/7 8YyW80I9atodaeq3BFqOazE6xFFiJ1s2fiD9rJVFtIZnc5Dkw4u4DYtq3IrVHrDX8d7j 3Oz5Zrgq9h9lOxt4MztS/gaviNXXtpoB8Jm/6Wj/Su9rsQBGC9vzLw+3DGhZI23HyI8m Hi0vLvAfXuBYmtHJzvQX7uVTmv+EGF33wdYStCoXd5RMEIoLTh2oXMa/57n/oni4oQWc EIaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=aDg494jtgErGqiuDA2DRjeEz9+0QgIkJR2NqCdRXVXs=; b=oxdzRFYWB2Xv+pzZyTvqPdk5U0v5MmtyzEIoP4w8QaA4+dFFzFgiHaG0ppB1jkvGq8 S3/s+Oi5v4+mX6WluuoRDizUCHm2BzYvd7JwvSMHFB+peufnC+UwfKW096/sywm8quBW tM7cBoL7h/OfTRyCP3/cZ2uOBY1XSZSiFrao9UbFHTEfSBAh+6PvXZhEuLkzIP/wgk9z dWsZlsk4u1kwtoGfqiiA7M22j34L3QfQILI0O/TqlglCBJVHVK26+NdXz6L5I13bQRir vJE/z1JkiYqzIRAulGfD0W1VDhTrhM+2oW72yOWGY3DcX8Aofn8IuK9QgOezU8NHNzQf sorg== X-Gm-Message-State: APjAAAXuat3tS+0kl75uC5ukc/m312DXhjGxOhS7UvpEbHBr/SH2vB5X sGUvK5TxRtbAnbmKOoVOP1Q= X-Google-Smtp-Source: APXvYqxE2tf4lUtg4StdijZm2lopmjoepVgVdckkNo4w96q0iYq0OpIyWBgaJxwrQCgVWVDC0Y7GRw== X-Received: by 2002:a63:ef05:: with SMTP id u5mr32644220pgh.177.1553662651013; Tue, 26 Mar 2019 21:57:31 -0700 (PDT) Received: from localhost.localdomain ([2001:268:c0a5:6014:c70:4af9:86e2:2]) by smtp.gmail.com with ESMTPSA id z6sm61151922pgo.31.2019.03.26.21.57.25 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 26 Mar 2019 21:57:30 -0700 (PDT) From: William Breathitt Gray To: linus.walleij@linaro.org, bgolaszewski@baylibre.com Cc: akpm@linux-foundation.org, linux-gpio@vger.kernel.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, andriy.shevchenko@linux.intel.com, linux@rasmusvillemoes.dk, yamada.masahiro@socionext.com, linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org, geert@linux-m68k.org, preid@electromag.com.au, William Breathitt Gray Subject: [PATCH v13 00/11] Introduce the for_each_set_clump8 macro Date: Wed, 27 Mar 2019 13:57:55 +0900 Message-Id: X-Mailer: git-send-email 2.21.0 MIME-Version: 1.0 Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Changes in v13: - Reimplement find_next_clump8 to leverage find_next_bit - Restrict bitmap_get_value8/bitmap_set_value8 start argument to values that are multiples of 8; this prevents cases where a clump lands between word boundaries - Trim const qualifiers from bitmap_get_value8, bitmap_set_value8, and find_next_clump8; this should help improve readability of the code - Redefine parameter list for bitmap_get_value8, bitmap_set_value8, and find_next_clump8 to use unsigned long in order to match the find_next_bit data types and naming conventions While adding GPIO get_multiple/set_multiple callback support for various drivers, I noticed a pattern of looping manifesting that would be useful standardized as a macro. This patchset introduces the for_each_set_clump8 macro and utilizes it in several GPIO drivers. The for_each_set_clump macro8 facilitates a for-loop syntax that iterates over a memory region entire groups of set bits at a time. For example, suppose you would like to iterate over a 32-bit integer 8 bits at a time, skipping over 8-bit groups with no set bit, where XXXXXXXX represents the current 8-bit group: Example: 10111110 00000000 11111111 00110011 First loop: 10111110 00000000 11111111 XXXXXXXX Second loop: 10111110 00000000 XXXXXXXX 00110011 Third loop: XXXXXXXX 00000000 11111111 00110011 Each iteration of the loop returns the next 8-bit group that has at least one set bit. The for_each_set_clump8 macro has four parameters: * start: set to the bit offset of the current clump * clump: set to the current clump value * bits: bitmap to search within * size: bitmap size in number of bits In this version of the patchset, the for_each_set_clump macro has been reimplemented and simplified based on the suggestions provided by Rasmus Villemoes and Andy Shevchenko in the version 4 submission. In particular, the function of the for_each_set_clump macro has been restricted to handle only 8-bit clumps; the drivers that use the for_each_set_clump macro only handle 8-bit ports so a generic for_each_set_clump implementation is not necessary. Thus, a solution for large clumps (i.e. those larger than the width of a bitmap word) can be postponed until a driver appears that actually requires such a generic for_each_set_clump implementation. For what it's worth, a semi-generic for_each_set_clump (i.e. for clumps smaller than the width of a bitmap word) can be implemented by simply replacing the hardcoded '8' and '0xFF' instances with respective variables. I have not yet had a need for such an implementation, and since it falls short of a true generic for_each_set_clump function, I have decided to forgo such an implementation for now. In addition, the bitmap_get_value8 and bitmap_set_value8 functions are introduced to get and set 8-bit values respectively. Their use is based on the behavior suggested in the patchset version 4 review. William Breathitt Gray (11): bitops: Introduce the for_each_set_clump8 macro lib/test_bitmap.c: Add for_each_set_clump8 test cases gpio: 104-dio-48e: Utilize for_each_set_clump8 macro gpio: 104-idi-48: Utilize for_each_set_clump8 macro gpio: gpio-mm: Utilize for_each_set_clump8 macro gpio: ws16c48: Utilize for_each_set_clump8 macro gpio: pci-idio-16: Utilize for_each_set_clump8 macro gpio: pcie-idio-24: Utilize for_each_set_clump8 macro gpio: uniphier: Utilize for_each_set_clump8 macro gpio: 74x164: Utilize the for_each_set_clump8 macro thermal: intel: intel_soc_dts_iosf: Utilize for_each_set_clump8 macro drivers/gpio/gpio-104-dio-48e.c | 73 ++++---------- drivers/gpio/gpio-104-idi-48.c | 36 ++----- drivers/gpio/gpio-74x164.c | 19 ++-- drivers/gpio/gpio-gpio-mm.c | 73 ++++---------- drivers/gpio/gpio-pci-idio-16.c | 75 +++++--------- drivers/gpio/gpio-pcie-idio-24.c | 109 ++++++++------------- drivers/gpio/gpio-uniphier.c | 16 ++- drivers/gpio/gpio-ws16c48.c | 73 ++++---------- drivers/thermal/intel/intel_soc_dts_iosf.c | 29 +++--- drivers/thermal/intel/intel_soc_dts_iosf.h | 2 - include/asm-generic/bitops/find.h | 11 +++ include/linux/bitops.h | 5 + lib/find_bit.c | 58 +++++++++++ lib/test_bitmap.c | 65 ++++++++++++ 14 files changed, 307 insertions(+), 337 deletions(-)