mbox series

[v3,0/3] pinctrl: pinctrl-zynqmp: Add Versal platform support

Message ID 20240801120029.1807180-1-sai.krishna.potthuri@amd.com
Headers show
Series pinctrl: pinctrl-zynqmp: Add Versal platform support | expand

Message

Potthuri, Sai Krishna Aug. 1, 2024, noon UTC
Update the binding and pinctrl-zynqmp driver to add Versal platform
support.
Add Get Attribute ID in the Xilinx firmware driver to get the pin
information from Xilinx Platform Management Firmware.

Changes in v3:
-> 1/3 - Mentioned all group names in conf node and also defined the
         conf node properties in $defs (suggested by Rob).

Changes in v2:
-> 1/3 - Created new binding doc for Versal platform (suggested by Rob).
-> 1/3 - Update regex for pins properties to make sure it always starts
         with "LPD" or "PMC" string.
-> 3/3 - Used firmware API to get platform information to differentiate
         platform specific code (suggested by Jay).

Sai Krishna Potthuri (3):
  dt-bindings: pinctrl: Add support for Xilinx Versal platform
  firmware: xilinx: Add Pinctrl Get Attribute ID
  pinctrl: pinctrl-zynqmp: Add support for Versal platform

 .../bindings/pinctrl/xlnx,versal-pinctrl.yaml | 398 ++++++++++++++++++
 drivers/pinctrl/pinctrl-zynqmp.c              |  97 ++++-
 include/linux/firmware/xlnx-zynqmp.h          |   1 +
 3 files changed, 491 insertions(+), 5 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/pinctrl/xlnx,versal-pinctrl.yaml

Comments

Krzysztof Kozlowski Aug. 4, 2024, 2:49 p.m. UTC | #1
On 01/08/2024 14:00, Sai Krishna Potthuri wrote:
> Update the binding and pinctrl-zynqmp driver to add Versal platform
> support.
> Add Get Attribute ID in the Xilinx firmware driver to get the pin
> information from Xilinx Platform Management Firmware.

Any particular reason why you are developing patches on some quite old
kernel?

Best regards,
Krzysztof
Potthuri, Sai Krishna Aug. 5, 2024, 8:58 a.m. UTC | #2
Hi Krzysztof,

> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Sent: Sunday, August 4, 2024 8:20 PM
> To: Potthuri, Sai Krishna <sai.krishna.potthuri@amd.com>; Linus Walleij
> <linus.walleij@linaro.org>; Simek, Michal <michal.simek@amd.com>; Rob
> Herring <robh+dt@kernel.org>; Krzysztof Kozlowski
> <krzysztof.kozlowski+dt@linaro.org>; Conor Dooley <conor+dt@kernel.org>;
> Buddhabhatti, Jay <jay.buddhabhatti@amd.com>; Kundanala, Praveen Teja
> <praveen.teja.kundanala@amd.com>; Greg Kroah-Hartman
> <gregkh@linuxfoundation.org>
> Cc: linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org;
> linux-gpio@vger.kernel.org; devicetree@vger.kernel.org;
> saikrishna12468@gmail.com; git (AMD-Xilinx) <git@amd.com>
> Subject: Re: [PATCH v3 0/3] pinctrl: pinctrl-zynqmp: Add Versal platform
> support
> 
> On 01/08/2024 14:00, Sai Krishna Potthuri wrote:
> > Update the binding and pinctrl-zynqmp driver to add Versal platform
> > support.
> > Add Get Attribute ID in the Xilinx firmware driver to get the pin
> > information from Xilinx Platform Management Firmware.
> 
> Any particular reason why you are developing patches on some quite old
> kernel?
I created this patch series on top of latest Pin control subsystem tree(Linus Walleij),
'for-next' branch.

Regards
Sai Krishna
Krzysztof Kozlowski Aug. 5, 2024, 10:02 a.m. UTC | #3
On 05/08/2024 10:58, Potthuri, Sai Krishna wrote:
> Hi Krzysztof,
> 
>> -----Original Message-----
>> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> Sent: Sunday, August 4, 2024 8:20 PM
>> To: Potthuri, Sai Krishna <sai.krishna.potthuri@amd.com>; Linus Walleij
>> <linus.walleij@linaro.org>; Simek, Michal <michal.simek@amd.com>; Rob
>> Herring <robh+dt@kernel.org>; Krzysztof Kozlowski
>> <krzysztof.kozlowski+dt@linaro.org>; Conor Dooley <conor+dt@kernel.org>;
>> Buddhabhatti, Jay <jay.buddhabhatti@amd.com>; Kundanala, Praveen Teja
>> <praveen.teja.kundanala@amd.com>; Greg Kroah-Hartman
>> <gregkh@linuxfoundation.org>
>> Cc: linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org;
>> linux-gpio@vger.kernel.org; devicetree@vger.kernel.org;
>> saikrishna12468@gmail.com; git (AMD-Xilinx) <git@amd.com>
>> Subject: Re: [PATCH v3 0/3] pinctrl: pinctrl-zynqmp: Add Versal platform
>> support
>>
>> On 01/08/2024 14:00, Sai Krishna Potthuri wrote:
>>> Update the binding and pinctrl-zynqmp driver to add Versal platform
>>> support.
>>> Add Get Attribute ID in the Xilinx firmware driver to get the pin
>>> information from Xilinx Platform Management Firmware.
>>
>> Any particular reason why you are developing patches on some quite old
>> kernel?
> I created this patch series on top of latest Pin control subsystem tree(Linus Walleij),
> 'for-next' branch.

I have doubts... otherwise get_maintainers.pl would point different
address. Assuming you indeed use for-next branch, then sending process
is wrong - you use some unusual commands instead of expected
get_maintainers.pl or b4.

Best regards,
Krzysztof