mbox series

[libgpiod,v3,0/4] tools: tests: fix a few issues in bash scripts

Message ID 20240528-fix-bash-tests-v3-0-e9b5be2ba8bf@linaro.org
Headers show
Series tools: tests: fix a few issues in bash scripts | expand

Message

Bartosz Golaszewski May 28, 2024, 8:25 a.m. UTC 
Fix a few issues with tools tests reported by Andy.

Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
---
Changes in v3:
- Use $* in the message string in assert_fail()
- Make shellcheck happy when using find exclusively instead of find + grep
- Link to v2: https://lore.kernel.org/r/20240527-fix-bash-tests-v2-0-05d90cea24cd@linaro.org

Changes in v2:
- Use double quotes around $@ to prevent globbing but allow variable expansion
- Link to v1: https://lore.kernel.org/r/20240524-fix-bash-tests-v1-0-1397c73073a6@linaro.org

---
Bartosz Golaszewski (4):
      tools: tests: use tabs for indentation consistently
      tools: tests: use "$@" instead of $*
      tools: tests: remove unneeded ';' in while loops
      tools: tests: remove dependency on grep

 tools/gpio-tools-test.bash | 46 ++++++++++++++++++----------------------------
 1 file changed, 18 insertions(+), 28 deletions(-)
---
base-commit: 27fe10150f6d5fa78d1a1ef1e922dc8395d1154d
change-id: 20240524-fix-bash-tests-545bf26447b3

Best regards,

Comments

Kent Gibson May 28, 2024, 8:34 a.m. UTC | #1 
On Tue, May 28, 2024 at 10:25:47AM +0200, Bartosz Golaszewski wrote:
> Fix a few issues with tools tests reported by Andy.
>
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

Looks good to me.

Reviewed-by: Kent Gibson <warthog618@gmail.com>

> ---
> Changes in v3:
> - Use $* in the message string in assert_fail()
> - Make shellcheck happy when using find exclusively instead of find + grep
> - Link to v2: https://lore.kernel.org/r/20240527-fix-bash-tests-v2-0-05d90cea24cd@linaro.org
>
> Changes in v2:
> - Use double quotes around $@ to prevent globbing but allow variable expansion
> - Link to v1: https://lore.kernel.org/r/20240524-fix-bash-tests-v1-0-1397c73073a6@linaro.org
>
> ---
> Bartosz Golaszewski (4):
>       tools: tests: use tabs for indentation consistently
>       tools: tests: use "$@" instead of $*
>       tools: tests: remove unneeded ';' in while loops
>       tools: tests: remove dependency on grep
>
>  tools/gpio-tools-test.bash | 46 ++++++++++++++++++----------------------------
>  1 file changed, 18 insertions(+), 28 deletions(-)
> ---
> base-commit: 27fe10150f6d5fa78d1a1ef1e922dc8395d1154d
> change-id: 20240524-fix-bash-tests-545bf26447b3
>
> Best regards,
> --
> Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>
Andy Shevchenko May 29, 2024, 1:18 p.m. UTC | #2 
On Tue, May 28, 2024 at 04:34:05PM +0800, Kent Gibson wrote:
> On Tue, May 28, 2024 at 10:25:47AM +0200, Bartosz Golaszewski wrote:
> > Fix a few issues with tools tests reported by Andy.
> >
> > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> 
> Looks good to me.
> 
> Reviewed-by: Kent Gibson <warthog618@gmail.com>

And okay to me,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Bartosz Golaszewski May 29, 2024, 1:54 p.m. UTC | #3 
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>


On Tue, 28 May 2024 10:25:47 +0200, Bartosz Golaszewski wrote:
> Fix a few issues with tools tests reported by Andy.
> 
> 

Applied, thanks!

[1/4] tools: tests: use tabs for indentation consistently
      commit: 649b2baedd9042bbffa7f2e2847375b23c5adc2e
[2/4] tools: tests: use "$@" instead of $*
      commit: 4fae395c7c169e09441589ee64797cb62343da7d
[3/4] tools: tests: remove unneeded ';' in while loops
      commit: d75d591af73e2ebe52137221f4d87ce23f6c22d8
[4/4] tools: tests: remove dependency on grep
      commit: b569b91ce1e1749a4e4832e636721d3c05712593

Best regards,