mbox series

[00/23] gpio: Convert to platform remove callback returning void

Message ID 20230928070706.2290137-1-u.kleine-koenig@pengutronix.de
Headers show
Series gpio: Convert to platform remove callback returning void | expand

Message

Uwe Kleine-König Sept. 28, 2023, 7:06 a.m. UTC 
Hello,

this series converts all platform drivers below drivers/gpio to use
.remove_new(). The motivation is to get rid of an integer return code
that is (mostly) ignored by the platform driver core and error prone on
the driver side.

See commit 5c5a7680e67b ("platform: Provide a remove callback that
returns no value") for an extended explanation and the eventual goal.

There are no interdependencies between the patches. As there are still
quite a few drivers to convert, I'm happy about every patch that makes
it in. So even if there is a merge conflict with one patch until you
apply or a subject prefix is suboptimal, please apply the remainder of
this series anyhow.

Best regards
Uwe

Uwe Kleine-König (23):
  gpio: altera: Convert to platform remove callback returning void
  gpio: amdpt: Convert to platform remove callback returning void
  gpio: brcmstb: Convert to platform remove callback returning void
  gpio: cadence: Convert to platform remove callback returning void
  gpio: dln2: Convert to platform remove callback returning void
  gpio: ftgpio010: Convert to platform remove callback returning void
  gpio: grgpio: Convert to platform remove callback returning void
  gpio: ljca: Convert to platform remove callback returning void
  gpio: lpc18xx: Convert to platform remove callback returning void
  gpio: mb86s7x: Convert to platform remove callback returning void
  gpio: mm-lantiq: Convert to platform remove callback returning void
  gpio: mpc5200: Convert to platform remove callback returning void
  gpio: mpc8xxx: Convert to platform remove callback returning void
  gpio: omap: Convert to platform remove callback returning void
  gpio: rcar: Convert to platform remove callback returning void
  gpio: rockchip: Convert to platform remove callback returning void
  gpio: tb10x: Convert to platform remove callback returning void
  gpio: ts5500: Convert to platform remove callback returning void
  gpio: uniphier: Convert to platform remove callback returning void
  gpio: xgene-sb: Convert to platform remove callback returning void
  gpio: xgs-iproc: Convert to platform remove callback returning void
  gpio: xilinx: Convert to platform remove callback returning void
  gpio: zynq: Convert to platform remove callback returning void

 drivers/gpio/gpio-altera.c    | 6 ++----
 drivers/gpio/gpio-amdpt.c     | 6 ++----
 drivers/gpio/gpio-brcmstb.c   | 6 ++----
 drivers/gpio/gpio-cadence.c   | 6 ++----
 drivers/gpio/gpio-dln2.c      | 6 ++----
 drivers/gpio/gpio-ftgpio010.c | 6 ++----
 drivers/gpio/gpio-grgpio.c    | 6 ++----
 drivers/gpio/gpio-ljca.c      | 5 ++---
 drivers/gpio/gpio-lpc18xx.c   | 6 ++----
 drivers/gpio/gpio-mb86s7x.c   | 6 ++----
 drivers/gpio/gpio-mm-lantiq.c | 6 ++----
 drivers/gpio/gpio-mpc5200.c   | 8 +++-----
 drivers/gpio/gpio-mpc8xxx.c   | 6 ++----
 drivers/gpio/gpio-omap.c      | 6 ++----
 drivers/gpio/gpio-rcar.c      | 5 ++---
 drivers/gpio/gpio-rockchip.c  | 6 ++----
 drivers/gpio/gpio-tb10x.c     | 6 ++----
 drivers/gpio/gpio-ts5500.c    | 6 ++----
 drivers/gpio/gpio-uniphier.c  | 6 ++----
 drivers/gpio/gpio-xgene-sb.c  | 6 ++----
 drivers/gpio/gpio-xgs-iproc.c | 6 ++----
 drivers/gpio/gpio-xilinx.c    | 6 ++----
 drivers/gpio/gpio-zynq.c      | 5 ++---
 23 files changed, 47 insertions(+), 90 deletions(-)


base-commit: 719136e5c24768ebdf80b9daa53facebbdd377c3

Comments

Linus Walleij Sept. 28, 2023, 9:54 p.m. UTC | #1 
On Thu, Sep 28, 2023 at 9:07 AM Uwe Kleine-König
<u.kleine-koenig@pengutronix.de> wrote:

> this series converts all platform drivers below drivers/gpio to use
> .remove_new(). The motivation is to get rid of an integer return code
> that is (mostly) ignored by the platform driver core and error prone on
> the driver side.

The whole set looks good to me:
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij
Bartosz Golaszewski Oct. 2, 2023, 6:52 a.m. UTC | #2 
On Thu, Sep 28, 2023 at 9:07 AM Uwe Kleine-König
<u.kleine-koenig@pengutronix.de> wrote:
>
> Hello,
>
> this series converts all platform drivers below drivers/gpio to use
> .remove_new(). The motivation is to get rid of an integer return code
> that is (mostly) ignored by the platform driver core and error prone on
> the driver side.
>
> See commit 5c5a7680e67b ("platform: Provide a remove callback that
> returns no value") for an extended explanation and the eventual goal.
>
> There are no interdependencies between the patches. As there are still
> quite a few drivers to convert, I'm happy about every patch that makes
> it in. So even if there is a merge conflict with one patch until you
> apply or a subject prefix is suboptimal, please apply the remainder of
> this series anyhow.
>
> Best regards
> Uwe
>
> Uwe Kleine-König (23):
>   gpio: altera: Convert to platform remove callback returning void
>   gpio: amdpt: Convert to platform remove callback returning void
>   gpio: brcmstb: Convert to platform remove callback returning void
>   gpio: cadence: Convert to platform remove callback returning void
>   gpio: dln2: Convert to platform remove callback returning void
>   gpio: ftgpio010: Convert to platform remove callback returning void
>   gpio: grgpio: Convert to platform remove callback returning void
>   gpio: ljca: Convert to platform remove callback returning void
>   gpio: lpc18xx: Convert to platform remove callback returning void
>   gpio: mb86s7x: Convert to platform remove callback returning void
>   gpio: mm-lantiq: Convert to platform remove callback returning void
>   gpio: mpc5200: Convert to platform remove callback returning void
>   gpio: mpc8xxx: Convert to platform remove callback returning void
>   gpio: omap: Convert to platform remove callback returning void
>   gpio: rcar: Convert to platform remove callback returning void
>   gpio: rockchip: Convert to platform remove callback returning void
>   gpio: tb10x: Convert to platform remove callback returning void
>   gpio: ts5500: Convert to platform remove callback returning void
>   gpio: uniphier: Convert to platform remove callback returning void
>   gpio: xgene-sb: Convert to platform remove callback returning void
>   gpio: xgs-iproc: Convert to platform remove callback returning void
>   gpio: xilinx: Convert to platform remove callback returning void
>   gpio: zynq: Convert to platform remove callback returning void
>
>  drivers/gpio/gpio-altera.c    | 6 ++----
>  drivers/gpio/gpio-amdpt.c     | 6 ++----
>  drivers/gpio/gpio-brcmstb.c   | 6 ++----
>  drivers/gpio/gpio-cadence.c   | 6 ++----
>  drivers/gpio/gpio-dln2.c      | 6 ++----
>  drivers/gpio/gpio-ftgpio010.c | 6 ++----
>  drivers/gpio/gpio-grgpio.c    | 6 ++----
>  drivers/gpio/gpio-ljca.c      | 5 ++---
>  drivers/gpio/gpio-lpc18xx.c   | 6 ++----
>  drivers/gpio/gpio-mb86s7x.c   | 6 ++----
>  drivers/gpio/gpio-mm-lantiq.c | 6 ++----
>  drivers/gpio/gpio-mpc5200.c   | 8 +++-----
>  drivers/gpio/gpio-mpc8xxx.c   | 6 ++----
>  drivers/gpio/gpio-omap.c      | 6 ++----
>  drivers/gpio/gpio-rcar.c      | 5 ++---
>  drivers/gpio/gpio-rockchip.c  | 6 ++----
>  drivers/gpio/gpio-tb10x.c     | 6 ++----
>  drivers/gpio/gpio-ts5500.c    | 6 ++----
>  drivers/gpio/gpio-uniphier.c  | 6 ++----
>  drivers/gpio/gpio-xgene-sb.c  | 6 ++----
>  drivers/gpio/gpio-xgs-iproc.c | 6 ++----
>  drivers/gpio/gpio-xilinx.c    | 6 ++----
>  drivers/gpio/gpio-zynq.c      | 5 ++---
>  23 files changed, 47 insertions(+), 90 deletions(-)
>
>
> base-commit: 719136e5c24768ebdf80b9daa53facebbdd377c3
> --
> 2.40.1
>

Series queued for v6.7, thanks!

Bart