| Message ID | 20220712143237.13992-1-henning.schild@siemens.com |
|---|---|
| Headers | show |
| Series | add device driver for Nuvoton SIO gpio function | expand |
On Tue, Jul 12, 2022 at 4:32 PM Henning Schild <henning.schild@siemens.com> wrote: > > changes since v2: > - move from subsys_initcall to module_init > - add 2 more patches to show how it can be used later > - v2 is based on [PATCH v6 00/12] platform/x86: introduce p2sb_bar() helper > > changes since v1: > - implement get_direction function > - style changes requested in review JFYI: You have a strange subject. Had you used `git format-patch --cover-letter ...`? > This adds gpio support for several Super IO chips from Nuvoton. The > driver was originally developed by Nuvoton and i am just contributing it > on behalf, because other patches i will send later will require access > to the gpios. The driver is valid on its own. > In fact v2 of this series shows a future user, not to be merged right > away but to show what is planned. > > The driver supports several chips, of which i only managed to test one > but did not want to drop the others. > > I hope the original authors will help with the testing and addressing > review feedback. The changes i did so far mainly are inspired by similar > drivers and some just concern coding style. If more has to be done and > the original authors do not jump in, we might start off with just that > one chip i can test and add the others later on.
Am Tue, 12 Jul 2022 16:32:34 +0200 schrieb Henning Schild <henning.schild@siemens.com>: > changes since v2: - moved Kconfig switch to correct section > - move from subsys_initcall to module_init > - add 2 more patches to show how it can be used later > - v2 is based on [PATCH v6 00/12] platform/x86: introduce p2sb_bar() > helper > > changes since v1: > - implement get_direction function > - style changes requested in review > > This adds gpio support for several Super IO chips from Nuvoton. The > driver was originally developed by Nuvoton and i am just contributing > it on behalf, because other patches i will send later will require > access to the gpios. The driver is valid on its own. > In fact v2 of this series shows a future user, not to be merged right > away but to show what is planned. > > The driver supports several chips, of which i only managed to test one > but did not want to drop the others. > > I hope the original authors will help with the testing and addressing > review feedback. The changes i did so far mainly are inspired by > similar drivers and some just concern coding style. If more has to be > done and the original authors do not jump in, we might start off with > just that one chip i can test and add the others later on. > > Henning Schild (3): > gpio: nct6116d: add new driver for several Nuvoton super io chips > leds: simatic-ipc-leds-gpio: add new model 227G > platform/x86: simatic-ipc: enable watchdog for 227G > > drivers/gpio/Kconfig | 9 + > drivers/gpio/Makefile | 1 + > drivers/gpio/gpio-nct6116d.c | 412 > ++++++++++++++++++ drivers/leds/simple/simatic-ipc-leds-gpio.c | > 42 +- drivers/platform/x86/simatic-ipc.c | 7 +- > .../platform_data/x86/simatic-ipc-base.h | 1 + > include/linux/platform_data/x86/simatic-ipc.h | 1 + > 7 files changed, 467 insertions(+), 6 deletions(-) > create mode 100644 drivers/gpio/gpio-nct6116d.c >
Am Tue, 12 Jul 2022 16:42:46 +0200 schrieb Andy Shevchenko <andy.shevchenko@gmail.com>: > On Tue, Jul 12, 2022 at 4:32 PM Henning Schild > <henning.schild@siemens.com> wrote: > > > > changes since v2: > > - move from subsys_initcall to module_init > > - add 2 more patches to show how it can be used later > > - v2 is based on [PATCH v6 00/12] platform/x86: introduce > > p2sb_bar() helper > > > > changes since v1: > > - implement get_direction function > > - style changes requested in review > > JFYI: You have a strange subject. Had you used `git format-patch > --cover-letter ...`? Yes, but i changed that subject. Took the old line and turned v2 into v3. What is strange about it? Henning > > This adds gpio support for several Super IO chips from Nuvoton. The > > driver was originally developed by Nuvoton and i am just > > contributing it on behalf, because other patches i will send later > > will require access to the gpios. The driver is valid on its own. > > In fact v2 of this series shows a future user, not to be merged > > right away but to show what is planned. > > > > The driver supports several chips, of which i only managed to test > > one but did not want to drop the others. > > > > I hope the original authors will help with the testing and > > addressing review feedback. The changes i did so far mainly are > > inspired by similar drivers and some just concern coding style. If > > more has to be done and the original authors do not jump in, we > > might start off with just that one chip i can test and add the > > others later on. > >
On Tue, Jul 12, 2022 at 5:16 PM Henning Schild <henning.schild@siemens.com> wrote: > > Am Tue, 12 Jul 2022 16:42:46 +0200 > schrieb Andy Shevchenko <andy.shevchenko@gmail.com>: > > On Tue, Jul 12, 2022 at 4:32 PM Henning Schild > > <henning.schild@siemens.com> wrote: > > JFYI: You have a strange subject. Had you used `git format-patch > > --cover-letter ...`? > > Yes, but i changed that subject. Took the old line and turned v2 into > v3. What is strange about it? The 0/1 while it has to be 0/3.
Am Tue, 12 Jul 2022 17:22:45 +0200 schrieb Andy Shevchenko <andy.shevchenko@gmail.com>: > On Tue, Jul 12, 2022 at 5:16 PM Henning Schild > <henning.schild@siemens.com> wrote: > > > > Am Tue, 12 Jul 2022 16:42:46 +0200 > > schrieb Andy Shevchenko <andy.shevchenko@gmail.com>: > > > On Tue, Jul 12, 2022 at 4:32 PM Henning Schild > > > <henning.schild@siemens.com> wrote: > > > > JFYI: You have a strange subject. Had you used `git format-patch > > > --cover-letter ...`? > > > > Yes, but i changed that subject. Took the old line and turned v2 > > into v3. What is strange about it? > > The 0/1 while it has to be 0/3. A right, copy/paste mistake. Henning