| Message ID | 20240522192524.3286237-1-eajames@linux.ibm.com |
|---|---|
| Headers | show |
| Series | ARM: dts: aspeed: Add IBM P11 BMC systems | expand |
Hi Eddie, > + > + led@6 { > + reg = <6>; > + default-state = "keep"; > + label = "opencapi-connector5"; > + retain-state-shutdown; > + type = <PCA955X_TYPE_LED>; > + }; is led@7 not connected? > + > + led@8 { > + reg = <8>; > + default-state = "keep"; > + label = "vrm4"; > + retain-state-shutdown; > + type = <PCA955X_TYPE_LED>; > + }; > + > + led@9 { > + reg = <9>; > + default-state = "keep"; > + label = "vrm5"; > + retain-state-shutdown; > + type = <PCA955X_TYPE_LED>; > + }; > + > + led@10 { > + reg = <10>; > + default-state = "keep"; > + label = "vrm6"; > + retain-state-shutdown; > + type = <PCA955X_TYPE_LED>; > + }; > + > + led@11 { > + reg = <11>; > + default-state = "keep"; > + label = "vrm7"; > + retain-state-shutdown; > + type = <PCA955X_TYPE_LED>; > + }; > + > + led@12 { > + reg = <12>; > + default-state = "keep"; > + label = "vrm12"; > + retain-state-shutdown; > + type = <PCA955X_TYPE_LED>; > + }; curious about label jump from vrm7 to vrm12. > > + cfam4_i2c10: i2c-bus@a { > + reg = <10>; /* OP3A */ > + #address-cells = <1>; > + #size-cells = <0>; > + > It will be more readable to have "reg" value in hex too. I have seen similar stuff in this FSI nodes. It will be consistent with other places. > + Reviewed-by: Ninad Palsule <ninad@linux.ibm.com>
On 5/28/24 09:08, Ninad Palsule wrote: > > Hi Eddie, > >> + >> + led@6 { >> + reg = <6>; >> + default-state = "keep"; >> + label = "opencapi-connector5"; >> + retain-state-shutdown; >> + type = <PCA955X_TYPE_LED>; >> + }; > is led@7 not connected? Correct. >> + >> + led@8 { >> + reg = <8>; >> + default-state = "keep"; >> + label = "vrm4"; >> + retain-state-shutdown; >> + type = <PCA955X_TYPE_LED>; >> + }; >> + >> + led@9 { >> + reg = <9>; >> + default-state = "keep"; >> + label = "vrm5"; >> + retain-state-shutdown; >> + type = <PCA955X_TYPE_LED>; >> + }; >> + >> + led@10 { >> + reg = <10>; >> + default-state = "keep"; >> + label = "vrm6"; >> + retain-state-shutdown; >> + type = <PCA955X_TYPE_LED>; >> + }; >> + >> + led@11 { >> + reg = <11>; >> + default-state = "keep"; >> + label = "vrm7"; >> + retain-state-shutdown; >> + type = <PCA955X_TYPE_LED>; >> + }; >> + >> + led@12 { >> + reg = <12>; >> + default-state = "keep"; >> + label = "vrm12"; >> + retain-state-shutdown; >> + type = <PCA955X_TYPE_LED>; >> + }; > curious about label jump from vrm7 to vrm12. vrm0-3 and 8-11 are on the previous pca chip. I believe this is correct based on the wiring in the spec, though the numberings are really just convention established by the guy who managed the LEDs on the system. >> + cfam4_i2c10: i2c-bus@a { >> + reg = <10>; /* OP3A */ >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> It will be more readable to have "reg" value in hex too. I have seen similar stuff in this FSI nodes. It will be consistent with other places. >> + > > Reviewed-by: Ninad Palsule <ninad@linux.ibm.com> > Sure, thanks! Eddie
On 5/22/24 14:25, Eddie James wrote: > Add the Blueridge and Fuji BMC systems. Document many missing FSI related > properties, and fix existing warnings. Make some minor fixes in OCC and > SCOM drivers for the updated bindings. Hi Joel/Andrew, what else needs to be fixed before this can be merged (minus Huygens patch which I will resend)? I believe all the patches have been reviewed. Thanks, Eddie > > Changes since v5: > - Switch from clock-frequency to bus-frequency for common FSI controller > properties > - Add reg properties for AST2700 FSI controller > - Fix patternProperties for i2c bus nodes under FSI-based I2C controller > - Add bus-frequency for P11 FSI device tree node > - Change model name from Blueridge to Blueridge 2U > - Add missing reset gpio to led controller on Fuji > - Add Huygens (Rainier with modified FSI wiring) > > Eddie James (20): > spi: dt-bindings: Document the IBM FSI-attached SPI controller > dt-bindings: fsi: fsi2spi: Document SPI controller child nodes > dt-bindings: fsi: Document the IBM SCOM engine > dt-bindings: fsi: p9-occ: Convert to json-schema > dt-bindings: fsi: Document the IBM SBEFIFO engine > dt-bindings: fsi: Document the FSI controller common properties > dt-bindings: fsi: ibm,i2cr-fsi-master: Reference common FSI controller > dt-bindings: fsi: ast2600-fsi-master: Convert to json-schema > dt-bindings: fsi: Document the AST2700 FSI controller > dt-bindings: fsi: Document the FSI Hub Controller > dt-bindings: i2c: i2c-fsi: Convert to json-schema > dt-bindings: arm: aspeed: add IBM P11 BMC boards > ARM: dts: aspeed: Add IBM P11 FSI devices > ARM: dts: aspeed: Add IBM P11 Blueridge BMC system > ARM: dts: aspeed: Add IBM P11 Blueridge 4U BMC system > ARM: dts: aspeed: Add IBM P11 Fuji BMC system > ARM: dts: aspeed: Add IBM Huygens BMC system > fsi: occ: Get device number from FSI minor number API > fsi: occ: Find next available child rather than node name match > fsi: scom: Update compatible string to match documentation > > .../bindings/arm/aspeed/aspeed.yaml | 2 + > .../fsi/aspeed,ast2600-fsi-master.yaml | 121 + > .../bindings/fsi/fsi-controller.yaml | 66 + > .../bindings/fsi/fsi-master-aspeed.txt | 36 - > .../devicetree/bindings/fsi/ibm,fsi2spi.yaml | 36 +- > .../bindings/fsi/ibm,i2cr-fsi-master.yaml | 5 +- > .../bindings/fsi/ibm,p9-fsi-controller.yaml | 45 + > .../devicetree/bindings/fsi/ibm,p9-occ.txt | 16 - > .../devicetree/bindings/fsi/ibm,p9-occ.yaml | 40 + > .../bindings/fsi/ibm,p9-sbefifo.yaml | 46 + > .../devicetree/bindings/fsi/ibm,p9-scom.yaml | 37 + > .../devicetree/bindings/i2c/i2c-fsi.txt | 40 - > .../devicetree/bindings/i2c/ibm,i2c-fsi.yaml | 76 + > .../devicetree/bindings/spi/ibm,spi-fsi.yaml | 55 + > MAINTAINERS | 2 +- > arch/arm/boot/dts/aspeed/Makefile | 3 + > .../aspeed/aspeed-bmc-ibm-blueridge-4u.dts | 21 + > .../dts/aspeed/aspeed-bmc-ibm-blueridge.dts | 1691 +++++++ > .../boot/dts/aspeed/aspeed-bmc-ibm-fuji.dts | 3881 +++++++++++++++++ > .../dts/aspeed/aspeed-bmc-ibm-huygens.dts | 23 + > .../arm/boot/dts/aspeed/ibm-power11-quad.dtsi | 1539 +++++++ > drivers/fsi/fsi-occ.c | 49 +- > drivers/fsi/fsi-scom.c | 1 + > 23 files changed, 7694 insertions(+), 137 deletions(-) > create mode 100644 Documentation/devicetree/bindings/fsi/aspeed,ast2600-fsi-master.yaml > create mode 100644 Documentation/devicetree/bindings/fsi/fsi-controller.yaml > delete mode 100644 Documentation/devicetree/bindings/fsi/fsi-master-aspeed.txt > create mode 100644 Documentation/devicetree/bindings/fsi/ibm,p9-fsi-controller.yaml > delete mode 100644 Documentation/devicetree/bindings/fsi/ibm,p9-occ.txt > create mode 100644 Documentation/devicetree/bindings/fsi/ibm,p9-occ.yaml > create mode 100644 Documentation/devicetree/bindings/fsi/ibm,p9-sbefifo.yaml > create mode 100644 Documentation/devicetree/bindings/fsi/ibm,p9-scom.yaml > delete mode 100644 Documentation/devicetree/bindings/i2c/i2c-fsi.txt > create mode 100644 Documentation/devicetree/bindings/i2c/ibm,i2c-fsi.yaml > create mode 100644 Documentation/devicetree/bindings/spi/ibm,spi-fsi.yaml > create mode 100644 arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-blueridge-4u.dts > create mode 100644 arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-blueridge.dts > create mode 100644 arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-fuji.dts > create mode 100644 arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-huygens.dts > create mode 100644 arch/arm/boot/dts/aspeed/ibm-power11-quad.dtsi >
Hi Eddie, On Wed, 2024-06-05 at 10:47 -0500, Eddie James wrote: > On 5/22/24 14:25, Eddie James wrote: > > Add the Blueridge and Fuji BMC systems. Document many missing FSI related > > properties, and fix existing warnings. Make some minor fixes in OCC and > > SCOM drivers for the updated bindings. > > > Hi Joel/Andrew, what else needs to be fixed before this can be merged > (minus Huygens patch which I will resend)? I believe all the patches > have been reviewed. > Firstly, thanks for your work here on the FSI bindings. However, the series is a bit awkward, as it sandwiches Aspeed devicetree patches that should go through Joel's bmc tree between the bindings and driver fixes that should go through the FSI tree. This is potentially less of a problem for Joel as he's the maintainer for both, but it's not my place to be touching the FSI tree. For now I've applied the dts patches and pushed them here after dropping the Huygens patch: https://github.com/amboar/linux/commits/for/bmc/dt-6.11/ But I would appreciate it if you split series by subsystem in the future (see my comments on the other FSI series you have out for review). Andrew > > Thanks, > > Eddie > > > > > > Changes since v5: > > - Switch from clock-frequency to bus-frequency for common FSI controller > > properties > > - Add reg properties for AST2700 FSI controller > > - Fix patternProperties for i2c bus nodes under FSI-based I2C controller > > - Add bus-frequency for P11 FSI device tree node > > - Change model name from Blueridge to Blueridge 2U > > - Add missing reset gpio to led controller on Fuji > > - Add Huygens (Rainier with modified FSI wiring) > > > > Eddie James (20): > > spi: dt-bindings: Document the IBM FSI-attached SPI controller > > dt-bindings: fsi: fsi2spi: Document SPI controller child nodes > > dt-bindings: fsi: Document the IBM SCOM engine > > dt-bindings: fsi: p9-occ: Convert to json-schema > > dt-bindings: fsi: Document the IBM SBEFIFO engine > > dt-bindings: fsi: Document the FSI controller common properties > > dt-bindings: fsi: ibm,i2cr-fsi-master: Reference common FSI controller > > dt-bindings: fsi: ast2600-fsi-master: Convert to json-schema > > dt-bindings: fsi: Document the AST2700 FSI controller > > dt-bindings: fsi: Document the FSI Hub Controller > > dt-bindings: i2c: i2c-fsi: Convert to json-schema > > dt-bindings: arm: aspeed: add IBM P11 BMC boards > > ARM: dts: aspeed: Add IBM P11 FSI devices > > ARM: dts: aspeed: Add IBM P11 Blueridge BMC system > > ARM: dts: aspeed: Add IBM P11 Blueridge 4U BMC system > > ARM: dts: aspeed: Add IBM P11 Fuji BMC system > > ARM: dts: aspeed: Add IBM Huygens BMC system > > fsi: occ: Get device number from FSI minor number API > > fsi: occ: Find next available child rather than node name match > > fsi: scom: Update compatible string to match documentation > > > > .../bindings/arm/aspeed/aspeed.yaml | 2 + > > .../fsi/aspeed,ast2600-fsi-master.yaml | 121 + > > .../bindings/fsi/fsi-controller.yaml | 66 + > > .../bindings/fsi/fsi-master-aspeed.txt | 36 - > > .../devicetree/bindings/fsi/ibm,fsi2spi.yaml | 36 +- > > .../bindings/fsi/ibm,i2cr-fsi-master.yaml | 5 +- > > .../bindings/fsi/ibm,p9-fsi-controller.yaml | 45 + > > .../devicetree/bindings/fsi/ibm,p9-occ.txt | 16 - > > .../devicetree/bindings/fsi/ibm,p9-occ.yaml | 40 + > > .../bindings/fsi/ibm,p9-sbefifo.yaml | 46 + > > .../devicetree/bindings/fsi/ibm,p9-scom.yaml | 37 + > > .../devicetree/bindings/i2c/i2c-fsi.txt | 40 - > > .../devicetree/bindings/i2c/ibm,i2c-fsi.yaml | 76 + > > .../devicetree/bindings/spi/ibm,spi-fsi.yaml | 55 + > > MAINTAINERS | 2 +- > > arch/arm/boot/dts/aspeed/Makefile | 3 + > > .../aspeed/aspeed-bmc-ibm-blueridge-4u.dts | 21 + > > .../dts/aspeed/aspeed-bmc-ibm-blueridge.dts | 1691 +++++++ > > .../boot/dts/aspeed/aspeed-bmc-ibm-fuji.dts | 3881 +++++++++++++++++ > > .../dts/aspeed/aspeed-bmc-ibm-huygens.dts | 23 + > > .../arm/boot/dts/aspeed/ibm-power11-quad.dtsi | 1539 +++++++ > > drivers/fsi/fsi-occ.c | 49 +- > > drivers/fsi/fsi-scom.c | 1 + > > 23 files changed, 7694 insertions(+), 137 deletions(-) > > create mode 100644 Documentation/devicetree/bindings/fsi/aspeed,ast2600-fsi-master.yaml > > create mode 100644 Documentation/devicetree/bindings/fsi/fsi-controller.yaml > > delete mode 100644 Documentation/devicetree/bindings/fsi/fsi-master-aspeed.txt > > create mode 100644 Documentation/devicetree/bindings/fsi/ibm,p9-fsi-controller.yaml > > delete mode 100644 Documentation/devicetree/bindings/fsi/ibm,p9-occ.txt > > create mode 100644 Documentation/devicetree/bindings/fsi/ibm,p9-occ.yaml > > create mode 100644 Documentation/devicetree/bindings/fsi/ibm,p9-sbefifo.yaml > > create mode 100644 Documentation/devicetree/bindings/fsi/ibm,p9-scom.yaml > > delete mode 100644 Documentation/devicetree/bindings/i2c/i2c-fsi.txt > > create mode 100644 Documentation/devicetree/bindings/i2c/ibm,i2c-fsi.yaml > > create mode 100644 Documentation/devicetree/bindings/spi/ibm,spi-fsi.yaml > > create mode 100644 arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-blueridge-4u.dts > > create mode 100644 arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-blueridge.dts > > create mode 100644 arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-fuji.dts > > create mode 100644 arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-huygens.dts > > create mode 100644 arch/arm/boot/dts/aspeed/ibm-power11-quad.dtsi > >
On Wed, May 22, 2024 at 02:25:04PM -0500, Eddie James wrote: > Add the Blueridge and Fuji BMC systems. Document many missing FSI related > properties, and fix existing warnings. Make some minor fixes in OCC and > SCOM drivers for the updated bindings. > > Changes since v5: > - Switch from clock-frequency to bus-frequency for common FSI controller > properties > - Add reg properties for AST2700 FSI controller > - Fix patternProperties for i2c bus nodes under FSI-based I2C controller > - Add bus-frequency for P11 FSI device tree node > - Change model name from Blueridge to Blueridge 2U > - Add missing reset gpio to led controller on Fuji > - Add Huygens (Rainier with modified FSI wiring) > > Eddie James (20): > spi: dt-bindings: Document the IBM FSI-attached SPI controller > dt-bindings: fsi: fsi2spi: Document SPI controller child nodes > dt-bindings: fsi: Document the IBM SCOM engine > dt-bindings: fsi: p9-occ: Convert to json-schema > dt-bindings: fsi: Document the IBM SBEFIFO engine > dt-bindings: fsi: Document the FSI controller common properties > dt-bindings: fsi: ibm,i2cr-fsi-master: Reference common FSI controller > dt-bindings: fsi: ast2600-fsi-master: Convert to json-schema > dt-bindings: fsi: Document the AST2700 FSI controller > dt-bindings: fsi: Document the FSI Hub Controller > dt-bindings: i2c: i2c-fsi: Convert to json-schema Looks like these haven't been applied, so I applied patches 2-11. > dt-bindings: arm: aspeed: add IBM P11 BMC boards > ARM: dts: aspeed: Add IBM P11 FSI devices > ARM: dts: aspeed: Add IBM P11 Blueridge BMC system > ARM: dts: aspeed: Add IBM P11 Blueridge 4U BMC system > ARM: dts: aspeed: Add IBM P11 Fuji BMC system > ARM: dts: aspeed: Add IBM Huygens BMC system > fsi: occ: Get device number from FSI minor number API > fsi: occ: Find next available child rather than node name match > fsi: scom: Update compatible string to match documentation