From patchwork Sat Feb 26 20:40:19 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Amir Goldstein X-Patchwork-Id: 84671 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id AE1A7B70DB for ; Sun, 27 Feb 2011 07:40:22 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752644Ab1BZUkV (ORCPT ); Sat, 26 Feb 2011 15:40:21 -0500 Received: from mail-qw0-f46.google.com ([209.85.216.46]:40728 "EHLO mail-qw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752513Ab1BZUkU (ORCPT ); Sat, 26 Feb 2011 15:40:20 -0500 Received: by qwd7 with SMTP id 7so2007203qwd.19 for ; Sat, 26 Feb 2011 12:40:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:date:message-id:subject:from:to:cc :content-type; bh=Zd7ctBkqWAqLNxWxgOHdGk59QswTjaDA+i+QSg8BMFA=; b=N6AuvE/AGA5p50WsG3TrNHarja7eGwJXb+FktYGI+2H+8mFja8kQBiWc4vmYnKqOr6 Hv9OLJYHXi/X8FRg77mOB4CnpjaWi6Fp0kxDhanMCa+7+tkoUbQKAx94MethIgJFHSW9 WT1J4CuiyV3Mw+CeKOnOzIzJu3WOH9fGBT24s= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:date:message-id:subject:from:to:cc:content-type; b=c0TTK/og6tUpuUFhvw2+7Vu8tV6V6ndS3lODMUci22MNUqcLEbQojCJWPrCAvrYKvb UIlntVbpMueLo+IKutCTNhmUfWqXkpeRyhk411zfOTN+Dt9bqNp82RseLcrhJzaLjoyL sDLvZUlW1xAUiP1+ZOfAWXOEKXifq89OiYvJI= MIME-Version: 1.0 Received: by 10.229.221.149 with SMTP id ic21mr3211101qcb.190.1298752819919; Sat, 26 Feb 2011 12:40:19 -0800 (PST) Received: by 10.229.96.71 with HTTP; Sat, 26 Feb 2011 12:40:19 -0800 (PST) Date: Sat, 26 Feb 2011 22:40:19 +0200 Message-ID: Subject: [PATCH] ext3: skip orphan cleanup on rocompat fs From: Amir Goldstein To: Jan Kara Cc: Theodore Tso , Ext4 Developers List Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org Orphan cleanup is currently executed even on readonly mount. It deletes inodes and frees blocks, which could be very bad for some RO_COMPAT features, HAS_SNAPSHOT to name one. Now the damage is done, because current stock kernels may corrupt future fs with readonly compatible features, when doing orphan cleanup. This patch skips the orphan cleanup if readonly compatible features would prevent the fs from being mounted (or remounted) readwrite. Signed-off-by: Amir Goldstein --- fs/ext3/super.c | 7 +++++++ 1 files changed, 7 insertions(+), 0 deletions(-) -- 1.7.0.4 -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/fs/ext3/super.c b/fs/ext3/super.c index 85c8cc8..6cdd575 100644 --- a/fs/ext3/super.c +++ b/fs/ext3/super.c @@ -1464,6 +1464,13 @@ static void ext3_orphan_cleanup (struct super_block * sb, return; } + /* Check if feature set allows readwrite operations */ + if (EXT3_HAS_RO_COMPAT_FEATURE(sb, ~EXT3_FEATURE_RO_COMPAT_SUPP)) { + ext3_msg(sb, KERN_INFO, "Skipping orphan cleanup on readonly-" + "compatible fs"); + return; + } + if (EXT3_SB(sb)->s_mount_state & EXT3_ERROR_FS) { if (es->s_last_orphan) jbd_debug(1, "Errors on filesystem, "