From patchwork Mon Jul 23 08:03:14 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wang Sheng-Hui X-Patchwork-Id: 172566 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 130F42C00BF for ; Mon, 23 Jul 2012 18:03:32 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752466Ab2GWID3 (ORCPT ); Mon, 23 Jul 2012 04:03:29 -0400 Received: from mail-pb0-f46.google.com ([209.85.160.46]:40564 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752389Ab2GWID0 (ORCPT ); Mon, 23 Jul 2012 04:03:26 -0400 Received: by pbbrp8 with SMTP id rp8so10485348pbb.19 for ; Mon, 23 Jul 2012 01:03:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject :content-type:content-transfer-encoding; bh=njdw/tJgchhk2yEc1ehVkAgK+vdX6OcItSmB/GYw/dc=; b=LlaDR99oBgHz0nsRwgyVxU4Sj95E0+fsEznLTIKBZ2WXgKWf0jxwXnOgSAKFHACOwf nYATEkwYYQVGWNrmYCA3zsLGRj0jkkhfFwfmCISzz/QMYOjwYl/Ke5+/QUD9Z3eT3V2S 3Sak5atm0qH/AAmj1x6vqEmz0fNg1R8OssEq1EuksFygF35aQTGzkX6OSi0yPCvCR91S nhXkZ/m5l/9jLq9U5ofzhDJF+lNRQ7NnJ4y1U1/VzClMnslVO3lRP5kXbBFB87qn8hj1 sJFeryDsIKSlcwPyrl/OIZYdPOyUHudCV3fD2TZ+wn4T1H2ns9bU9Cycg6CMnp4UGd4K zSxw== Received: by 10.68.220.231 with SMTP id pz7mr32931527pbc.110.1343030605949; Mon, 23 Jul 2012 01:03:25 -0700 (PDT) Received: from [9.115.120.158] ([202.108.130.138]) by mx.google.com with ESMTPS id nu5sm9482813pbb.53.2012.07.23.01.03.22 (version=SSLv3 cipher=OTHER); Mon, 23 Jul 2012 01:03:24 -0700 (PDT) Message-ID: <500D0542.1020000@gmail.com> Date: Mon, 23 Jul 2012 16:03:14 +0800 From: Wang Sheng-Hui User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.18) Gecko/20110617 Thunderbird/3.1.11 MIME-Version: 1.0 To: Andreas Dilger , Theodore Ts'o , ext4 development , linux-kernel@vger.kernel.org Subject: [PATCH] ext4: remove redundant offset check in move_extents.c/mext_check_arguments Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org In the check code above, if orig_start != donor_start, we would return -EINVAL. So here, orig_start should be equal with donor_start. Remove the redundant check here. Signed-off-by: Wang Sheng-Hui --- fs/ext4/move_extent.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/fs/ext4/move_extent.c b/fs/ext4/move_extent.c index c5826c6..8383257 100644 --- a/fs/ext4/move_extent.c +++ b/fs/ext4/move_extent.c @@ -1002,7 +1002,6 @@ mext_check_arguments(struct inode *orig_inode, } if ((orig_start >= EXT_MAX_BLOCKS) || - (donor_start >= EXT_MAX_BLOCKS) || (*len > EXT_MAX_BLOCKS) || (orig_start + *len >= EXT_MAX_BLOCKS)) { ext4_debug("ext4 move extent: Can't handle over [%u] blocks "