| Message ID | 20240715063447.391668-1-bottaawesome633@gmail.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v4,1/2] locking/lockdep: Forcing subclasses to have same name pointer as their parent class | expand |
On Mon, Jul 15, 2024 at 09:34:46AM +0300, botta633 wrote: > From: Ahmed Ehab <bottaawesome633@gmail.com> > > Preventing lockdep_set_subclass from creating a new instance of the > string literal. Hence, we will always have the same class->name among > parent and subclasses. This prevents kernel panics when looking up a > lock class while comparing class locks and class names. > > Reported-by: <syzbot+7f4a6f7f7051474e40ad@syzkaller.appspotmail.com> > Fixes: de8f5e4f2dc1f ("lockdep: Introduce wait-type checks") > Cc: <stable@vger.kernel.org> > Signed-off-by: Ahmed Ehab <bottaawesome633@gmail.com> > --- > include/linux/lockdep.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Hi, This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree. You are receiving this message because of the following common error(s) as indicated below: - This looks like a new version of a previously submitted patch, but you did not list below the --- line any changes from the previous version. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/process/submitting-patches.rst for what needs to be done here to properly describe this. If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers. thanks, greg k-h's patch email bot
diff --git a/include/linux/lockdep.h b/include/linux/lockdep.h index 08b0d1d9d78b..df8fa5929de7 100644 --- a/include/linux/lockdep.h +++ b/include/linux/lockdep.h @@ -173,7 +173,7 @@ static inline void lockdep_init_map(struct lockdep_map *lock, const char *name, (lock)->dep_map.lock_type) #define lockdep_set_subclass(lock, sub) \ - lockdep_init_map_type(&(lock)->dep_map, #lock, (lock)->dep_map.key, sub,\ + lockdep_init_map_type(&(lock)->dep_map, (lock)->dep_map.name, (lock)->dep_map.key, sub,\ (lock)->dep_map.wait_type_inner, \ (lock)->dep_map.wait_type_outer, \ (lock)->dep_map.lock_type)