Message ID | 20230914150011.843330-5-willy@infradead.org |
---|---|
State | Not Applicable |
Headers | show
Return-Path: <SRS0=yFA3=E6=vger.kernel.org=linux-ext4-owner@ozlabs.org> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=infradead.org header.i=@infradead.org header.a=rsa-sha256 header.s=casper.20170209 header.b=iSf3gXJV; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=ozlabs.org (client-ip=2404:9400:2221:ea00::3; helo=gandalf.ozlabs.org; envelope-from=srs0=yfa3=e6=vger.kernel.org=linux-ext4-owner@ozlabs.org; receiver=patchwork.ozlabs.org) Received: from gandalf.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4RmgVH6Krtz1yhn for <incoming@patchwork.ozlabs.org>; Fri, 15 Sep 2023 01:00:23 +1000 (AEST) Received: from gandalf.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by gandalf.ozlabs.org (Postfix) with ESMTP id 4RmgVH4BxRz4x5J for <incoming@patchwork.ozlabs.org>; Fri, 15 Sep 2023 01:00:23 +1000 (AEST) Received: by gandalf.ozlabs.org (Postfix) id 4RmgVH3bcWz4x7q; Fri, 15 Sep 2023 01:00:23 +1000 (AEST) Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: gandalf.ozlabs.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: gandalf.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=infradead.org header.i=@infradead.org header.a=rsa-sha256 header.s=casper.20170209 header.b=iSf3gXJV; dkim-atps=neutral Authentication-Results: gandalf.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=2620:137:e000::1:20; helo=out1.vger.email; envelope-from=linux-ext4-owner@vger.kernel.org; receiver=ozlabs.org) Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by gandalf.ozlabs.org (Postfix) with ESMTP id 4RmgVH3Dmwz4x5J for <patchwork-incoming@ozlabs.org>; Fri, 15 Sep 2023 01:00:23 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240624AbjINPA1 (ORCPT <rfc822;patchwork-incoming@ozlabs.org>); Thu, 14 Sep 2023 11:00:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56064 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234000AbjINPAZ (ORCPT <rfc822;linux-ext4@vger.kernel.org>); Thu, 14 Sep 2023 11:00:25 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2DA831FC4; Thu, 14 Sep 2023 08:00:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description; bh=N2P1sP4TNHc1ikURftWXESxt7tBpXc+ocZgrSYl8k6Q=; b=iSf3gXJV000l4CXPDzPdP8QTq9 iRJUi8/JKqHD8BMpXh3aRjHcMY2dl6q8EHmpz6U4jjysgI5V2ZmCZh13536GcuWQ7RdgUOtZB9rz0 x2Gh7BWKWSur2qzhLaK9Che4uZuLEuq6b29J84PPkGU/op2y1hB40iQCqwpuf8uy9EtfIGet54f0s arUrxJZP24dRbiYkdCNnBorDZ8T0vEJadqzBTg4bbeuFhSAPQ5/6JaBi3Bnt5rjX94rb31eTrMVo0 IsSruJPk1n2kPUG/CT+FkxHxbWeDxtXBW7fsZ6kwsmPAhFLWGtZrclmlnbNXDrqE/TMlw1Vp23Ql9 jzWSYIaw==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qgnpF-003XOQ-W6; Thu, 14 Sep 2023 15:00:14 +0000 From: "Matthew Wilcox (Oracle)" <willy@infradead.org> To: akpm@linux-foundation.org Cc: "Matthew Wilcox (Oracle)" <willy@infradead.org>, Hui Zhu <teawater@antgroup.com>, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org Subject: [PATCH v2 4/8] buffer: Use bdev_getblk() to avoid memory reclaim in readahead path Date: Thu, 14 Sep 2023 16:00:07 +0100 Message-Id: <20230914150011.843330-5-willy@infradead.org> X-Mailer: git-send-email 2.37.1 In-Reply-To: <20230914150011.843330-1-willy@infradead.org> References: <20230914150011.843330-1-willy@infradead.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: <linux-ext4.vger.kernel.org> X-Mailing-List: linux-ext4@vger.kernel.org |
Series |
Add and use bdev_getblk()
|
expand
|
diff --git a/fs/buffer.c b/fs/buffer.c index 3fe293c9f3ca..58546bfd8903 100644 --- a/fs/buffer.c +++ b/fs/buffer.c @@ -1464,7 +1464,9 @@ EXPORT_SYMBOL(__getblk_gfp); */ void __breadahead(struct block_device *bdev, sector_t block, unsigned size) { - struct buffer_head *bh = __getblk(bdev, block, size); + struct buffer_head *bh = bdev_getblk(bdev, block, size, + GFP_NOWAIT | __GFP_MOVABLE); + if (likely(bh)) { bh_readahead(bh, REQ_RAHEAD); brelse(bh);
__getblk() adds __GFP_NOFAIL, which is unnecessary for readahead; we're quite comfortable with the possibility that we may not get a bh back. Switch to bdev_getblk() which does not include __GFP_NOFAIL. Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org> --- fs/buffer.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)