| Message ID | 20221111121029.3985561-2-chengzhihao1@huawei.com |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | dm thin: Fix ABBA deadlock between shrink_slab and dm_pool_abort_metadata | expand |
diff --git a/drivers/md/dm-bufio.c b/drivers/md/dm-bufio.c index 9c5ef818ca36..bb786c39545e 100644 --- a/drivers/md/dm-bufio.c +++ b/drivers/md/dm-bufio.c @@ -1858,6 +1858,8 @@ struct dm_bufio_client *dm_bufio_client_create(struct block_device *bdev, unsign dm_io_client_destroy(c->dm_io); bad_dm_io: mutex_destroy(&c->lock); + if (c->no_sleep) + static_branch_dec(&no_sleep_enabled); kfree(c); bad_client: return ERR_PTR(r);
The 'no_sleep_enabled' should be decreased in error handling path in dm_bufio_client_create() when flag DM_BUFIO_CLIENT_NO_SLEEP is set, otherwise static_branch_unlikely() will always return true even no dm_bufio_client instances has DM_BUFIO_CLIENT_NO_SLEEP flag. Fixes: 3c1c875d0586 ("dm bufio: conditionally enable branching for DM_BUFIO_CLIENT_NO_SLEEP") Signed-off-by: Zhihao Cheng <chengzhihao1@huawei.com> --- drivers/md/dm-bufio.c | 2 ++ 1 file changed, 2 insertions(+)