From patchwork Thu Mar 17 00:48:47 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Theodore Ts'o X-Patchwork-Id: 598865 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3qQV942rZLz9ssP for ; Thu, 17 Mar 2016 11:48:56 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=thunk.org header.i=@thunk.org header.b=c9ttlFUW; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752296AbcCQAsx (ORCPT ); Wed, 16 Mar 2016 20:48:53 -0400 Received: from imap.thunk.org ([74.207.234.97]:54372 "EHLO imap.thunk.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751433AbcCQAsw (ORCPT ); Wed, 16 Mar 2016 20:48:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=thunk.org; s=ef5046eb; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date; bh=np+Ju/sPu+Kd0TMiTplf2FvdjzCCSA0kMhxXIkr/TZo=; b=c9ttlFUWGDASrBrvWOkR7bwlf+t5iz6ZAkVXfGl+wcidqUy4YUr11t9E3pwp1u/DsIyu6lPhhL5gUoUxHvGY/1Q+AkuQICGRspa0Kozt7zfrOllWg+KOI7cVzgVeksh+McFND7SYAW6ufcnNJ+JGcopTP5WDG4KzUFQjIWKeK2s=; Received: from root (helo=closure.thunk.org) by imap.thunk.org with local-esmtp (Exim 4.84) (envelope-from ) id 1agM7M-0000uZ-2U; Thu, 17 Mar 2016 00:48:48 +0000 Received: by closure.thunk.org (Postfix, from userid 15806) id 625B582E3C0; Wed, 16 Mar 2016 20:48:47 -0400 (EDT) Date: Wed, 16 Mar 2016 20:48:47 -0400 From: Theodore Ts'o To: Andreas Dilger Cc: Li Xi , Jan Kara , Dave Chinner , linux-ext4 Subject: Re: Reporting project quota usage? Message-ID: <20160317004847.GG23593@thunk.org> References: <20160316052906.GA23610@thunk.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: tytso@thunk.org X-SA-Exim-Scanned: No (on imap.thunk.org); SAEximRunCond expanded to false Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Wed, Mar 16, 2016 at 03:49:31PM -0600, Andreas Dilger wrote: > > At one time I thought Dave was going to patch xfs_quota to try the quota > ioctls for "foreign" filesystems like ext4 that supported them, but I'm > not sure if that patch was landed, nor whether it has been released. > > On the opposite front, Jan was updating the generic quota tools to support > the XFS ioctls that project quota is using? It's quite possible I'm missing something, but it doesn't look like either has landed. I've hacked xfs_quota (not anything that I would want to submit for merging) so I can report usage project quota stats, and to be able to set hard and soft limits. But I was trying to figure out what we should be telling users who wanted to use Project Quota, but I'm pretty sure "pull down xfsprogs sources, and apply this hacky patch[1], and then when you use the tooll ignore a whole bunch of spurious warnings" is the right way to go. :-) I am also curious how Li Xi was testing the patches he sent me. - Ted [1] --- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/libxcmd/paths.c b/libxcmd/paths.c index 5c65737..6c69a35 100644 --- a/libxcmd/paths.c +++ b/libxcmd/paths.c @@ -301,8 +301,8 @@ fs_table_initialise_mounts( return errno; while ((mnt = getmntent(mtp)) != NULL) { - if (strcmp(mnt->mnt_type, "xfs") != 0) - continue; +// if (strcmp(mnt->mnt_type, "xfs") != 0) +// continue; if (!realpath(mnt->mnt_dir, rmnt_dir)) continue; if (!realpath(mnt->mnt_fsname, rmnt_fsname))