From patchwork Fri Jan 6 21:50:13 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Djalal Harouni X-Patchwork-Id: 134706 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 1234AB6F74 for ; Sat, 7 Jan 2012 08:47:29 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753048Ab2AFVrS (ORCPT ); Fri, 6 Jan 2012 16:47:18 -0500 Received: from numidia.opendz.org ([98.142.220.152]:60120 "EHLO numidia.opendz.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751714Ab2AFVrS (ORCPT ); Fri, 6 Jan 2012 16:47:18 -0500 Received: from localhost (localhost [127.0.0.1]) by numidia.opendz.org (Postfix) with ESMTPSA id 8A1A617B407D; Fri, 6 Jan 2012 21:47:11 +0000 (UTC) Date: Fri, 6 Jan 2012 22:50:13 +0100 From: Djalal Harouni To: Theodore Ts'o , Andreas Dilger Cc: linux-ext4@vger.kernel.org Subject: [PATCH] ext4: release donor reference when EXT4_IOC_MOVE_EXT ioctl fails Message-ID: <20120106215013.GA27957@dztty> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org When the EXT4_IOC_MOVE_EXT ioctl() fails on bigalloc file systems, we should jump to the 'mext_out' label to release the donor file reference. Signed-off-by: Djalal Harouni --- fs/ext4/ioctl.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/fs/ext4/ioctl.c b/fs/ext4/ioctl.c index a567968..034e147 100644 --- a/fs/ext4/ioctl.c +++ b/fs/ext4/ioctl.c @@ -237,7 +237,8 @@ setversion_out: EXT4_FEATURE_RO_COMPAT_BIGALLOC)) { ext4_msg(sb, KERN_ERR, "Online defrag not supported with bigalloc"); - return -EOPNOTSUPP; + err = -EOPNOTSUPP; + goto mext_out; } err = mnt_want_write(filp->f_path.mnt);