diff mbox

ext4: release donor reference when EXT4_IOC_MOVE_EXT ioctl fails

Message ID 20120106215013.GA27957@dztty
State Accepted, archived
Headers show

Commit Message

Djalal Harouni Jan. 6, 2012, 9:50 p.m. UTC
When the EXT4_IOC_MOVE_EXT ioctl() fails on bigalloc file systems, we
should jump to the 'mext_out' label to release the donor file reference.

Signed-off-by: Djalal Harouni <tixxdz@opendz.org>
---
 fs/ext4/ioctl.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

Comments

Theodore Ts'o Sept. 27, 2012, 2:59 a.m. UTC | #1
On Fri, Jan 06, 2012 at 10:50:13PM +0100, Djalal Harouni wrote:
> When the EXT4_IOC_MOVE_EXT ioctl() fails on bigalloc file systems, we
> should jump to the 'mext_out' label to release the donor file reference.
> 
> Signed-off-by: Djalal Harouni <tixxdz@opendz.org>

Thanks, applied!

					- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/fs/ext4/ioctl.c b/fs/ext4/ioctl.c
index a567968..034e147 100644
--- a/fs/ext4/ioctl.c
+++ b/fs/ext4/ioctl.c
@@ -237,7 +237,8 @@  setversion_out:
 			       EXT4_FEATURE_RO_COMPAT_BIGALLOC)) {
 			ext4_msg(sb, KERN_ERR,
 				 "Online defrag not supported with bigalloc");
-			return -EOPNOTSUPP;
+			err = -EOPNOTSUPP;
+			goto mext_out;
 		}
 
 		err = mnt_want_write(filp->f_path.mnt);